Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account events #1546

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Fix account events #1546

merged 2 commits into from
Sep 17, 2021

Conversation

ATGE
Copy link
Contributor

@ATGE ATGE commented Sep 16, 2021

Fixes #1545

Testing

  • ✔️ slcli --format json account events

allmightyspiff
allmightyspiff approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, dont worry about the analysis errors, those are new and I will likely set them to be ignored I think.

@allmightyspiff allmightyspiff added this to In progress in Q3 2021 via automation Sep 16, 2021
@allmightyspiff allmightyspiff merged commit b07176e into softlayer:master Sep 17, 2021
Q3 2021 automation moved this from In progress to Done Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@ATGE ATGE

Labels
Bug
Projects
No open projects
Q3 2021
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slcli account events shows invalid JSON
2 participants
@ATGE @allmightyspiff