Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pricing date to slcli order preset-list #1578

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Add pricing date to slcli order preset-list #1578

merged 1 commit into from
Feb 1, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jan 26, 2022

@allmightyspiff allmightyspiff added CLI Ordering Anything related to ordering labels Jan 26, 2022
@allmightyspiff allmightyspiff linked an issue Jan 26, 2022 that may be closed by this pull request
Add pricing date to slcli order preset-list #1574
Closed
@allmightyspiff
Copy link
Member

@edsonarios would you mind testing this change, thanks.

allmightyspiff
allmightyspiff approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks

@edsonarios
Copy link
Contributor

edsonarios commented Jan 31, 2022 •
edited
Loading

Screenshots of the feature
image
image
image

image

image

image
image
image
image

image

edsonarios
edsonarios approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit d3588cc into softlayer:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios edsonarios approved these changes

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI Ordering Anything related to ordering
Projects
No open projects
Q12022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pricing date to slcli order preset-list
3 participants
@caberos @allmightyspiff @edsonarios