Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Command slcli hardware|virtual monitoring #1593

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Mar 10, 2022

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall, just some slight formatting issues. And have each command define and send in its own object mask instead of adding it to the default mask please.

Thanks

SoftLayer/CLI/hardware/monitoring.py Outdated Show resolved Hide resolved
SoftLayer/CLI/virt/monitoring.py Outdated Show resolved Hide resolved
SoftLayer/CLI/virt/monitoring.py Outdated Show resolved Hide resolved
SoftLayer/managers/hardware.py Show resolved Hide resolved
SoftLayer/managers/vs.py Show resolved Hide resolved
@BrianSantivanez
Copy link

BrianSantivanez commented Mar 11, 2022

Running the help command
image

Running the command with a hardware
image

Running the command with a virtual
image

Testing the command with a hardware and virtual guest with 3123796 and 127061328 as ids respectively is falling

@allmightyspiff
Copy link
Member

@BrianSantivanez I think you are getting those errors because prettytable might not be installed in your environment.

Try running python setup.py install to see if that fixes it. If not, check to make sure ptable is NOT installed. ptable was removed in the most recent version as a dependency since its a very outdated package.

You should have the following.

$ pip show prettytable
Name: prettytable
Version: 3.0.0
$ pip show ptable
WARNING: Package(s) not found: ptable

image

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, thanks

Copy link

@BrianSantivanez BrianSantivanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running python setup.py install to see if that fixes it. If not, check to make sure ptable is NOT installed. ptable was removed in the most recent version as a dependency since its a very outdated package.

Thanks @allmightyspiff , the problem was that I had prettytable and ptable installed at the same time.

After correct the observations:
Running the command with a hardware
image

Running the command with a virtual
image

Looks good to me

@allmightyspiff allmightyspiff merged commit 2ce632b into softlayer:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New Command slcli hardware|virtual monitoring
3 participants