Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new columns on vlan list(premium, tags) #1645

Merged
merged 2 commits into from
May 19, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented May 18, 2022

#1644

slcli vlan list

image

@edsonarios
Copy link
Contributor

Screenshots of the test result
image
image

@@ -16,7 +16,9 @@
'datacenter',
'hardware',
'virtual_servers',
'public_ips']
'public_ips',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the table some titles start with a capital letter, but others are all lowercase, perhaps it should be ordered so that everything is with uppercase or lowercase

Copy link

@BrianSantivanez BrianSantivanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good to me

@allmightyspiff allmightyspiff linked an issue May 19, 2022 that may be closed by this pull request
@allmightyspiff allmightyspiff merged commit ab2fc76 into softlayer:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add the premium column on vlan list command
4 participants