Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating release job to actually publish to pypi #1680

Merged
merged 1 commit into from
Jul 6, 2022
Merged

updating release job to actually publish to pypi #1680

merged 1 commit into from
Jul 6, 2022

Conversation

allmightyspiff
Copy link
Member

Fixes #1675
Fixes #1581

@allmightyspiff allmightyspiff added the Core Issues dealing with core functionality label Jul 1, 2022
@allmightyspiff allmightyspiff self-assigned this Jul 1, 2022
caberos
caberos approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

edsonarios
edsonarios approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit c468ddb into softlayer:master Jul 6, 2022
@allmightyspiff allmightyspiff deleted the issues1675 branch July 6, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caberos caberos caberos approved these changes

@edsonarios edsonarios edsonarios approved these changes

Assignees

@allmightyspiff allmightyspiff

Labels
Core Issues dealing with core functionality
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix snapcraft build Update release process to publish for real
3 participants
@allmightyspiff @caberos @edsonarios