Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with printing tables that contained empty items #1697

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fixed an issue with printing tables that contained empty items #1697

merged 1 commit into from
Jul 18, 2022

Conversation

allmightyspiff
Copy link
Member

Fixed an issue where printing an empty list would cause Rich.Table to crash
Fixes #1658

Before

image

After

image

@allmightyspiff allmightyspiff self-assigned this Jul 14, 2022
@edsonarios
Copy link
Contributor

Screenshots of the test result
image
image

edsonarios
edsonarios approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit ce76700 into softlayer:master Jul 18, 2022
@allmightyspiff allmightyspiff deleted the issues1658 branch July 18, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios approved these changes

@caberos caberos Awaiting requested review from caberos

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@allmightyspiff allmightyspiff

Labels
Bug
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table fails with empty lists
2 participants
@allmightyspiff @edsonarios