Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vs user-access command #1741

Merged
merged 3 commits into from
Sep 8, 2022
Merged

add vs user-access command #1741

merged 3 commits into from
Sep 8, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Aug 29, 2022

@allmightyspiff allmightyspiff linked an issue Aug 30, 2022 that may be closed by this pull request
add vs user-access command #1739
Closed
allmightyspiff
allmightyspiff requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just change the username in the fixtrues, and the first line comment of the new command.

SoftLayer/CLI/virt/access.py Outdated Show resolved Hide resolved
SoftLayer/fixtures/SoftLayer_Virtual_Guest.py Outdated Show resolved Hide resolved
SoftLayer/fixtures/SoftLayer_Virtual_Guest.py Outdated Show resolved Hide resolved
@edsonarios
Copy link
Contributor

Screenshots of the test result
image

edsonarios
edsonarios approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comments, looks good to me

@allmightyspiff allmightyspiff merged commit 735112e into softlayer:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios edsonarios approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add vs user-access command
3 participants
@caberos @edsonarios @allmightyspiff