Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error running a subcommand in slcli #1754

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Unhandled error running a subcommand in slcli #1754

merged 3 commits into from
Sep 23, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Sep 21, 2022

allmightyspiff
allmightyspiff requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just be able to add return None to your except statements to fix the analysis error. Otherwise looks good.

@allmightyspiff allmightyspiff linked an issue Sep 21, 2022 that may be closed by this pull request
Unhandled error running a subcommand in slcli #1749
Closed
@allmightyspiff allmightyspiff merged commit 1bd004d into softlayer:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios Awaiting requested review from edsonarios

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
Bug CLI
Projects
No open projects
Q3 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled error running a subcommand in slcli
2 participants
@caberos @allmightyspiff