Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more information on hw credentials #1767

Merged
merged 3 commits into from
Oct 17, 2022
Merged

add more information on hw credentials #1767

merged 3 commits into from
Oct 17, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Oct 7, 2022

@edsonarios
Copy link
Contributor

Screenshots of the test result
image

@allmightyspiff allmightyspiff linked an issue Oct 7, 2022 that may be closed by this pull request
add more information to hardware credentials #1763
Closed
BrianSantivanez
BrianSantivanez reviewed Oct 7, 2022
View reviewed changes
Copy link

@BrianSantivanez BrianSantivanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
After the changes looks good to me

@allmightyspiff allmightyspiff merged commit eeb815f into softlayer:master Oct 17, 2022
@allmightyspiff allmightyspiff mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios left review comments

@BrianSantivanez BrianSantivanez BrianSantivanez left review comments

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q4 2022
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add more information to hardware credentials
4 participants
@caberos @edsonarios @allmightyspiff @BrianSantivanez