Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing preset-list pricing table #1782

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Fixing preset-list pricing table #1782

merged 2 commits into from
Oct 28, 2022

Conversation

allmightyspiff
Copy link
Member

image

Fixes #1778

@allmightyspiff
Improved price calculations for preset-list and updated some docs. Al…
702f7be 
…so no longer highlighting command help messages for now, might revert that later.
@allmightyspiff
fixing unit tests
e87db34
@allmightyspiff allmightyspiff self-assigned this Oct 27, 2022
@edsonarios
Copy link
Contributor

edsonarios commented Oct 28, 2022 •
edited
Loading

Screenshots of the test result

image
image

edsonarios
edsonarios approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit 0671651 into softlayer:master Oct 28, 2022
@allmightyspiff allmightyspiff deleted the issues1778 branch October 28, 2022 21:00
@allmightyspiff allmightyspiff mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios approved these changes

@caberos caberos Awaiting requested review from caberos

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@allmightyspiff allmightyspiff

Labels
Bug
Projects
No open projects
Q4 2022
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slcli order preset-list prices don't seem to match the portal
2 participants
@allmightyspiff @edsonarios