Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default filter on subnet list and fix the subnet detail #1801

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Remove default filter on subnet list and fix the subnet detail #1801

merged 6 commits into from
Dec 12, 2022

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Dec 2, 2022

allmightyspiff
allmightyspiff requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert network.list_subnets() to still accept filters. I just wanted the _filter['subnets']['subnetType'] = {'operation': '!= GLOBAL_IP'} filter removed, since its added by default

SoftLayer/managers/network.py Show resolved Hide resolved
SoftLayer/CLI/loadbal/order.py Outdated Show resolved Hide resolved
SoftLayer/CLI/subnet/list.py Outdated Show resolved Hide resolved
SoftLayer/CLI/subnet/list.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue Dec 12, 2022 that may be closed by this pull request
Remove default filter on subnet list #1800
Closed
@allmightyspiff allmightyspiff merged commit bdb57e8 into softlayer:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios Awaiting requested review from edsonarios

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q4 2022
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove default filter on subnet list
2 participants
@caberos @allmightyspiff