Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subnet route and subnet clear-route #1810

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Dec 27, 2022

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just add some documentation to help the users out. Thanks

@environment.pass_env
def cli(env, identifier, target, target_id):
def cli(env, identifier, target, target_resource):
"""Assigns the subnet to a target."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this documentation to include some usage examples similar to https://github.ibm.com/softlayer/softlayer-cli/blob/master/plugin/commands/subnet/route.go should also include a link to https://sldn.softlayer.com/reference/services/SoftLayer_Network_Subnet/route/ since this command takes a variety of options

@allmightyspiff allmightyspiff merged commit a236652 into softlayer:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants