Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Command: slcli user grant-access #1818

Merged
merged 2 commits into from
Jan 20, 2023
Merged

New Command: slcli user grant-access #1818

merged 2 commits into from
Jan 20, 2023

Conversation

BrianSantivanez
Copy link

Issue: #1816
Observations: slcli user grant-access command and unit tests were added

slcli user grant-access 8344222 --hardware 1532729 --virtual 132364928
Grant to access to hardware: 1532729
Grant to access to virtual guest: 132364928

@BrianSantivanez BrianSantivanez self-assigned this Jan 10, 2023
@allmightyspiff allmightyspiff linked an issue Jan 11, 2023 that may be closed by this pull request
New Command: slcli user grant-access #1816
Closed
allmightyspiff
allmightyspiff requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes needed thanks.

SoftLayer/CLI/user/grant_access.py Outdated Show resolved Hide resolved
SoftLayer/CLI/user/grant_access.py Outdated Show resolved Hide resolved
SoftLayer/CLI/user/grant_access.py Outdated Show resolved Hide resolved
SoftLayer/CLI/user/grant_access.py Outdated Show resolved Hide resolved
tests/CLI/modules/user_tests.py Show resolved Hide resolved
caberos
caberos approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsonarios
Copy link
Contributor

Screenshots of the test result
image

edsonarios
edsonarios approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit 7fdc73a into softlayer:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@caberos caberos caberos approved these changes

@edsonarios edsonarios edsonarios approved these changes

Assignees

@BrianSantivanez BrianSantivanez

Labels
New Feature
Projects
No open projects
Q1 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Command: slcli user grant-access
4 participants
@BrianSantivanez @edsonarios @allmightyspiff @caberos