Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user remove-access is not displaying all removed device access and its help command displaying error message #1824

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

BrianSantivanez
Copy link

Issue: #1823
Observations: The command was updated to print an message of each removed device access, the short flags were removed to can use short help flag and the help flags were updated to match with golang plugin

slcli user remove-access 8344222 --hardware 1532729 --virtual 132364928
Remove to access to hardware: 1532729
Remove to access to virtual guest: 132364928
slcli user remove-access -h
Usage: slcli user remove-access [OPTIONS] IDENTIFIER

        Remove access from a user to an specific device.

Example: slcli user remove-access 123456 --hardware 123456789

┌────┬─────────────┬─────────────────────────────┐
│    │ identifier  │                             │
│    │ --hardware  │ Hardware ID                 │
│    │ --virtual   │ Virtual Guest ID            │
│    │ --dedicated │ Dedicated host ID           │
│ -h │ --help      │ Show this message and exit. │
└────┴─────────────┴─────────────────────────────┘

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just convert to f strings. Thanks

SoftLayer/CLI/user/remove_access.py Outdated Show resolved Hide resolved
SoftLayer/CLI/user/remove_access.py Outdated Show resolved Hide resolved
SoftLayer/CLI/user/remove_access.py Outdated Show resolved Hide resolved
@edsonarios
Copy link
Contributor

Screenshots of the test result
image

Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@allmightyspiff allmightyspiff merged commit 40437dc into softlayer:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

user remove-access is not displaying all removed device access and its help command displaying error message
3 participants