Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flag to command slcli account events --date-min #1830

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

edsonarios
Copy link
Contributor

Issue link: #1827

softlayer-python/ (issue1827 *) $ slcli account events -h
Usage: slcli account events [OPTIONS]

        Summary and acknowledgement of upcoming and ongoing maintenance events

┌────┬────────────────┬───────────────────────────────────────────────────────────────────────────────────────────┐
│    │ --ack-all      │ Acknowledge every upcoming event. Doing so will turn off the popup in the control portal. │
│    │ --planned      │ Show only planned events.                                                                 │
│    │ --unplanned    │ Show only unplanned events.                                                               │
│    │ --announcement │ Show only announcement events.                                                            │
│    │ --date-min     │ Earliest date to retrieve events for [MM/DD/YYYY]. Default: 2 days ago.                   │
│ -h │ --help         │ Show this message and exit.                                                               │
└────┴────────────────┴───────────────────────────────────────────────────────────────────────────────────────────┘
softlayer-python/ (issue1827 *) $ slcli account events --date-min 13/07/2023
Date invalid, example date: mm/dd/yyyy, 01/15/2023.
softlayer-python/ (issue1827 *) $ slcli account events --date-min 01/07/2023
                                                                                                 Planned Events
┌──────────────────┬────────┬───────────┬────────────────────────────────────────────────────────────────────────────────────┬───────────┬───────┬──────────────────┬──────────────────┬──────────────┬─────────┐
│    Event Data    │   Id   │ Event ID  │ Subject                                                                            │  Status   │ Items │    Start Date    │     End Date     │ Acknowledged │ Updates │
├──────────────────┼────────┼───────────┼────────────────────────────────────────────────────────────────────────────────────┼───────────┼───────┼──────────────────┼──────────────────┼──────────────┼─────────┤
│ 2023-02-10 23:30 │ 359494 │ 151441478 │ VPC DAL AZ3 Network Maintenance                                                    │ Published │   0   │ 2023-02-10 23:30 │ 2023-02-11 09:30 │     True     │    1    │
│ 2023-02-06 18:02 │ 359294 │ 151377326 │ VPC TOR AZ3 Network Maintenance                                                    │ Published │   0   │ 2023-02-06 18:02 │ 2023-02-06 18:08 │     True     │    1    │
│ 2023-02-05 01:30 │ 359212 │ 151339650 │ VPC WDC AZ3 Network Maintenance                                                    │ Published │   0   │ 2023-02-05 01:30 │ 2023-02-05 11:30 │    False     │    1    │
│ 2023-02-03 23:30 │ 358644 │ 151132842 │ VPC DAL AZ2 Network Maintenance                                                    │ Published │   0   │ 2023-02-03 23:30 │ 2023-02-04 09:30 │    False     │    1    │
...

Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes please.

SoftLayer/managers/account.py Outdated Show resolved Hide resolved
SoftLayer/utils.py Show resolved Hide resolved
tests/managers/account_tests.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit 0a34dbb into softlayer:master Jan 25, 2023
@ramkishor-ch
Copy link
Contributor

Hi @allmightyspiff,

I have tested the changes.

Please find the screen shot for reference.

Screen Shot:
Screenshot 2023-07-03 at 4 43 19 PM

Thanks,
Ramkishor Chaladi.

Copy link
Contributor

@ramkishor-ch ramkishor-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Looks good.
Thanks,
Ramkishor Chaladi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add flag --date-min to command slcli account events
4 participants