-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Command: slcli virtual host-list
#1835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to waste all the work you did, but we already have slcli dedicatedhost list
, and I don't want to duplicate that code here.
Do add an alias for slcli vs host-list
like I mentioned in the routes.py file though. I just want both commands to use the same code.
Add the order
and owner
flags to slcli dedicatedhost list
. I'd prefer that the dedicatedhost manager build the actual filter though.
I'd also like to take this time to remove the cpu
, memory
, disk
filters from dedicatedhost list
since I don't think they add much value. I'd also like to change the table it creates to be like the one you are building in this change. We can also remove the --columns
option from the list command as well.
TODO
- Have
slcli vs host-list
route to SoftLayer.CLI.dedicatedhost.list - Add
order
andowner
options toslcli dedicatedhost list
- Remove
cpu
,memory
,disk
andcolumns
options fromslcli dedicatedhost list
- Update table to be the one you created in this pull request
- Undo updates you made to the account manager, since we will be using the dedicatedhost managers list_instances function instead.
I hope that all makes sense. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just address Daniel's comment and this will be good to go. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #1829
Observations: virtual host-list command was added with its unit tests