Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected error when using vlan list with --limit 0 or 999 and a lar… #1847

Merged
merged 2 commits into from
Feb 1, 2023
Merged

unexpected error when using vlan list with --limit 0 or 999 and a lar… #1847

merged 2 commits into from
Feb 1, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jan 27, 2023

edsonarios
edsonarios approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

allmightyspiff
allmightyspiff requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the default response for a null networkSpace to Direct Link
Add a unit test for getting a vlan with an empty networkSpace property as well.

Thanks

SoftLayer/CLI/vlan/list.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue Jan 30, 2023 that may be closed by this pull request
unexpected error when using vlan list with --limit 0 or 999 and a large number of vlans (>400) #1844
Closed
@allmightyspiff allmightyspiff merged commit a630e03 into softlayer:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@edsonarios edsonarios edsonarios approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
Bug
Projects
No open projects
Q1 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected error when using vlan list with --limit 0 or 999 and a large number of vlans (>400)
3 participants
@caberos @allmightyspiff @edsonarios