Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a new command on order items-cancelation #1929

Merged
merged 9 commits into from May 9, 2023
Merged

add a new command on order items-cancelation #1929

merged 9 commits into from May 9, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented May 2, 2023

@edsonarios
Copy link
Contributor

Screenshots of the test result
image

edsonarios
edsonarios approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@edsonarios edsonarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

allmightyspiff
allmightyspiff requested changes May 5, 2023
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes needed. Thanks

SoftLayer/CLI/order/cancelation.py Outdated Show resolved Hide resolved
SoftLayer/CLI/order/cancelation.py Outdated Show resolved Hide resolved
SoftLayer/managers/ordering.py Show resolved Hide resolved
SoftLayer/managers/ordering.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue May 5, 2023 that may be closed by this pull request
add a new command on order items-cancelation #1927
Closed
allmightyspiff
allmightyspiff requested changes May 8, 2023
View reviewed changes
SoftLayer/CLI/order/cancelation.py Outdated Show resolved Hide resolved
@ramkishor-ch
Copy link
Contributor

Hi,

I have "tested the changes".
Please find the screenshot for reference.

Screen Shot: 1
Screenshot 2023-05-09 at 4 20 23 PM

Thanks,
Ramkishor Chaladi.

ramkishor-ch
ramkishor-ch approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ramkishor-ch ramkishor-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I have "tested the changes".
Approving the Pull Request.
Thanks,
Ramkishor Chaladi.

@allmightyspiff allmightyspiff merged commit 13502c3 into softlayer:master May 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios approved these changes

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@ramkishor-ch ramkishor-ch ramkishor-ch approved these changes

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@caberos caberos

Labels
CLI New Feature
Projects
No open projects
Q2 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a new command on order items-cancelation
4 participants
@caberos @edsonarios @ramkishor-ch @allmightyspiff