Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the network vlan on hardware detail #1966

Merged
merged 4 commits into from Jun 12, 2023
Merged

update the network vlan on hardware detail #1966

merged 4 commits into from Jun 12, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented May 26, 2023

@edsonarios
Copy link
Contributor

Screenshots of the test result
image

@allmightyspiff allmightyspiff linked an issue Jun 1, 2023 that may be closed by this pull request
update the network vlan on hardware detail #1962
Closed
@ramkishor-ch
Copy link
Contributor

Hi,

I have "tested the changes".
Please find the screenshot for reference

Screen Shot: 1
Screenshot 2023-06-02 at 11 15 37 PM

Thanks,
Ramkishor Chaladi.

ramkishor-ch
ramkishor-ch approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@ramkishor-ch ramkishor-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I have "tested the changes".
Approving the Pull Request.
Thanks,
Ramkishor Chaladi.

@JayasilanJibm
Copy link
Contributor

Hi,

I have tested the changes. Looks fine to me.

Approving the pull request.

Thanks,
Jayasilan

Sharing the screenshot for further reference.

Screenshot 2023-06-12 at 12 20 19 PM

@allmightyspiff allmightyspiff merged commit 592804f into softlayer:master Jun 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsonarios edsonarios edsonarios left review comments

@BrianSantivanez BrianSantivanez BrianSantivanez left review comments

@ramkishor-ch ramkishor-ch ramkishor-ch approved these changes

@JayasilanJibm JayasilanJibm JayasilanJibm approved these changes

@allmightyspiff allmightyspiff Awaiting requested review from allmightyspiff

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q2 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update the network vlan on hardware detail
6 participants
@caberos @edsonarios @ramkishor-ch @JayasilanJibm @BrianSantivanez @allmightyspiff