New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F-String Updates - account/bandwidthblock #1975
Conversation
updated to f{}
update order.py file for f{}
Merge conflict happened
For large issues like #1547 I prefer we create 'child' issues for each pull request like this one. Can you create a new issue to go along with this pull request. Something like this: Title: Fstrings - account and block commands This lets me know what you are working on before you make the pull request, along with helping us show how much work goes on in this project. Also, when working on a feature, I recommend using a branch (not master) for the next one. jsut a simple |
double quotes added in order_block_volume function
updated from to ''
added \'
added space
removed space
added \' in different unit test case function
added \' in different unit test case function
added f{} strings
removed blank line
Hi @allmightyspiff ,
Fixes #1976
I have updated line of code from .format() to f"{}" string.
Please review it and approve this pull request.
Please find the details.
Details:
Title: Fstrings - account, bandwidth and block commands
Start using python f-strings #1976
Description:
Account:
SoftLayer/CLI/account/billing_items.py
SoftLayer/CLI/account/billing_items.py
SoftLayer/CLI/account/cancel_item.py
SoftLayer/CLI/account/item_detail.py
SoftLayer/CLI/account/item_detail.py
SoftLayer/CLI/account/item_detail.py
Bandwidth:
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
Block:
SoftLayer/CLI/block/access/list.py
SoftLayer/CLI/block/access/list.py
SoftLayer/CLI/block/detail.py
SoftLayer/CLI/block/duplicate.py
SoftLayer/CLI/block/list.py
SoftLayer/CLI/block/modify.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/replication/locations.py
SoftLayer/CLI/block/replication/order.py
SoftLayer/CLI/block/replication/partners.py
SoftLayer/CLI/block/snapshot/get_notify_status.py
SoftLayer/CLI/block/snapshot/get_notify_status.py
SoftLayer/CLI/block/snapshot/list.py
SoftLayer/CLI/block/snapshot/order.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/remove.py
SoftLayer/CLI/block/subnets/remove.py
SoftLayer/CLI/block/subnets/remove.py
tests:
tests/CLI/modules/block_tests.py
Linked Issues: #1547
Thanks,
Ramkishor Chaladi.