Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-String Updates - account/bandwidthblock #1975

Merged
merged 14 commits into from Jun 12, 2023

Conversation

ramkishor-ch
Copy link
Contributor

@ramkishor-ch ramkishor-ch commented Jun 7, 2023

Hi @allmightyspiff ,

Fixes #1976

I have updated line of code from .format() to f"{}" string.

Please review it and approve this pull request.

Please find the details.

Details:

Title: Fstrings - account, bandwidth and block commands
Start using python f-strings #1976

Description:
Account:
SoftLayer/CLI/account/billing_items.py
SoftLayer/CLI/account/billing_items.py
SoftLayer/CLI/account/cancel_item.py
SoftLayer/CLI/account/item_detail.py
SoftLayer/CLI/account/item_detail.py
SoftLayer/CLI/account/item_detail.py

Bandwidth:
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py
SoftLayer/CLI/bandwidth/pools_detail.py

Block:
SoftLayer/CLI/block/access/list.py
SoftLayer/CLI/block/access/list.py
SoftLayer/CLI/block/detail.py
SoftLayer/CLI/block/duplicate.py
SoftLayer/CLI/block/list.py
SoftLayer/CLI/block/modify.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/order.py
SoftLayer/CLI/block/replication/locations.py
SoftLayer/CLI/block/replication/order.py
SoftLayer/CLI/block/replication/partners.py
SoftLayer/CLI/block/snapshot/get_notify_status.py
SoftLayer/CLI/block/snapshot/get_notify_status.py
SoftLayer/CLI/block/snapshot/list.py
SoftLayer/CLI/block/snapshot/order.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/assign.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/list.py
SoftLayer/CLI/block/subnets/remove.py
SoftLayer/CLI/block/subnets/remove.py
SoftLayer/CLI/block/subnets/remove.py

tests:
tests/CLI/modules/block_tests.py

Linked Issues: #1547

Thanks,
Ramkishor Chaladi.

updated to f{}
@ramkishor-ch ramkishor-ch added the Core Issues dealing with core functionality label Jun 7, 2023
@ramkishor-ch ramkishor-ch self-assigned this Jun 7, 2023
@ramkishor-ch ramkishor-ch linked an issue Jun 7, 2023 that may be closed by this pull request
Ramkishor Chaladi added 2 commits June 8, 2023 00:13
update order.py file for f{}
@allmightyspiff
Copy link
Member

For large issues like #1547 I prefer we create 'child' issues for each pull request like this one. Can you create a new issue to go along with this pull request. Something like this:

Title: Fstrings - account and block commands
Body: just mention what command groups you are working on or copy/paste the lines from the original issue.

This lets me know what you are working on before you make the pull request, along with helping us show how much work goes on in this project.

Also, when working on a feature, I recommend using a branch (not master) for the next one. jsut a simple git checkout -b issues<number> works great so you don't mix up code when working on multiple issues.

Ramkishor Chaladi added 2 commits June 8, 2023 01:24
double quotes added in order_block_volume function
updated from  to ''
@ramkishor-ch
Copy link
Contributor Author

ramkishor-ch commented Jun 7, 2023

Hi Christopher,

As suggested, I have created a child issue #1976 mentioned title and body from this parent issue #1547.

From next time onwards for a new pull request, I will use a branch to push the code changes.

Thanks,
Ramkishor Chaladi.

Ramkishor Chaladi added 6 commits June 8, 2023 01:44
added \'
added space
removed space
added \' in different unit test case function
added \' in different unit test case function
@ramkishor-ch ramkishor-ch linked an issue Jun 8, 2023 that may be closed by this pull request
@ramkishor-ch ramkishor-ch changed the title #1547 #1976 Jun 8, 2023
Ramkishor Chaladi added 2 commits June 8, 2023 13:45
added f{} strings
removed blank line
@allmightyspiff allmightyspiff changed the title #1976 F-String Updates - account/bandwidthblock Jun 12, 2023
SoftLayer/CLI/block/order.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit 2d490bf into softlayer:master Jun 12, 2023
10 checks passed
@allmightyspiff allmightyspiff linked an issue Jun 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues dealing with core functionality
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fstrings - account, bandwidth and block commands Start using python f-strings
2 participants