Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB protocol features #1999

Merged
merged 5 commits into from Jun 28, 2023
Merged

LB protocol features #1999

merged 5 commits into from Jun 28, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jun 21, 2023

#issue1986

protocol-add
image

protocol-edit
image

protocol-delete
image

@ramkishor-ch
Copy link
Contributor

ramkishor-ch commented Jun 26, 2023

Hi @allmightyspiff,

I have tested the changes.

Please find the screen shot for reference.

Screen Shot: 1
Screenshot 2023-06-26 at 7 45 04 PM

Screen Shot: 2

I have ordered a load balancer

Screenshot 2023-06-26 at 7 45 15 PM

Screen Shot: 3

I have added the protocol to the load balancer

Screenshot 2023-06-26 at 7 49 10 PM

Screen Shot: 4
Screenshot 2023-06-26 at 8 04 57 PM

Screen Shot: 5

I am editing the protocol to the load balancer

Screenshot 2023-06-26 at 8 05 08 PM

Screen Shot: 6

I am deleting the protocol to the load balancer

Screenshot 2023-06-26 at 8 06 46 PM

Thanks,
Ramkishor Chaladi.

@ramkishor-ch
Copy link
Contributor

Hi @allmightyspiff ,

I have a doubt in the code protocol_add.py file and protocol_edit.py file.

Where I see that a common function is being used in the both files.

Doubt:
Can we have a common function at common file because code can be optimized and from common file of common function can be used, is that fine?

Screen Shot 1:
Screenshot 2023-06-26 at 8 09 31 PM

Screen Shot 2:
Screenshot 2023-06-26 at 8 09 51 PM

Thanks,
Ramkishor Chaladi.

@allmightyspiff allmightyspiff linked an issue Jun 26, 2023 that may be closed by this pull request
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a few style related changes.

SoftLayer/CLI/loadbal/protocol_add.py Outdated Show resolved Hide resolved
SoftLayer/CLI/loadbal/protocol_add.py Outdated Show resolved Hide resolved
SoftLayer/CLI/loadbal/protocol_add.py Outdated Show resolved Hide resolved
SoftLayer/CLI/loadbal/protocol_edit.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit d873844 into softlayer:master Jun 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

LB protocol features
3 participants