Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slcli image list should use an iterative cal #2001

Merged
merged 3 commits into from Jul 13, 2023
Merged

slcli image list should use an iterative cal #2001

merged 3 commits into from Jul 13, 2023

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Jun 23, 2023

@allmightyspiff allmightyspiff added API Core Issues dealing with core functionality labels Jun 27, 2023
@allmightyspiff allmightyspiff linked an issue Jun 27, 2023 that may be closed by this pull request
slcli image list should use an iterative call #1993
Closed
allmightyspiff
allmightyspiff requested changes Jun 27, 2023
View reviewed changes
SoftLayer/managers/image.py Outdated Show resolved Hide resolved
@JayasilanJibm
Copy link
Contributor

Hi @caberos,

I have tested the code, seems like the image list is over 155. And with limit option as well it is different. Different output is observed each time.

Please let me know if I am doing it right or the API is returning the images in an arbitrary fashion.

Attached screenshots for further consideration.

Screenshot 2023-06-28 at 12 15 19 AM Screenshot 2023-06-28 at 12 15 40 AM Screenshot 2023-06-28 at 1 00 25 AM

Thanks,
Jayasilan

@caberos
Copy link
Contributor Author

caberos commented Jun 27, 2023

Hi @JayasilanJibm.

This command has multiples options to sent, as --public and --private options, in case not sent nothing option, this result is a sum between the public and private images.

image

Thanks
Caberos

@JayasilanJibm
Copy link
Contributor

Hi,

I have tested the code changes. The same result has been observed with limit option as well.

Approving this PR.

Please find the screenshot for further consideration.

Screenshot 2023-06-28 at 1 19 54 PM Screenshot 2023-06-28 at 1 20 04 PM

Thanks,
Jayasilan

allmightyspiff
allmightyspiff requested changes Jul 3, 2023
View reviewed changes
SoftLayer/managers/image.py Outdated Show resolved Hide resolved
SoftLayer/managers/image.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit 52365ba into softlayer:master Jul 13, 2023
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramkishor-ch ramkishor-ch ramkishor-ch left review comments

@allmightyspiff allmightyspiff allmightyspiff requested changes

@JayasilanJibm JayasilanJibm JayasilanJibm approved these changes

@edsonarios edsonarios Awaiting requested review from edsonarios

@BrianSantivanez BrianSantivanez Awaiting requested review from BrianSantivanez

Assignees

@JayasilanJibm JayasilanJibm

Labels
API Core Issues dealing with core functionality
Projects
No open projects
Q2 2023
Status: 🏗 In progress
Q3 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slcli image list should use an iterative call
4 participants
@caberos @JayasilanJibm @allmightyspiff @ramkishor-ch