Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example and sub feature for slcli firewall monitoring, slcli globalip specific commands #2033 #2056

Merged
merged 2 commits into from Aug 3, 2023
Merged

Example and sub feature for slcli firewall monitoring, slcli globalip specific commands #2033 #2056

merged 2 commits into from Aug 3, 2023

Conversation

JayasilanJibm
Copy link
Contributor

Hi,

Please review this PR.

Fixes: #2033

Example and sub feature for slcli firewall, slcli globalip assign,cancel,create,list command

Thanks,
Jayasilan

#2033
2119b84 
Example and sub feature for slcli firewall, slcli globalip assign,cancel,create,list command
@JayasilanJibm JayasilanJibm self-assigned this Jul 27, 2023
#2033
2d0f9f7 
Fixes for slcli globalip tests
@ramkishor-ch
Copy link
Contributor

Hi,

Code looks good.

Screen Shot:
Screenshot 2023-07-28 at 4 30 33 PM

Thanks,
Ramkishor Chaladi.

@allmightyspiff allmightyspiff merged commit c50ba73 into master Aug 3, 2023
10 checks passed
@allmightyspiff allmightyspiff deleted the jayasilan-issue2033 branch August 3, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@ramkishor-ch ramkishor-ch ramkishor-ch approved these changes

Assignees

@JayasilanJibm JayasilanJibm

Labels
CLI
Projects
No open projects
Q3 2023
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Description and Example were missing in slcli firewall monitoring, slcli globalip assign
3 participants
@JayasilanJibm @ramkishor-ch @allmightyspiff