Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ob/hook errors #27

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Ob/hook errors #27

merged 3 commits into from
Mar 16, 2023

Conversation

itsanolive
Copy link
Contributor

No description provided.

calebcurtis8
calebcurtis8 reviewed Mar 16, 2023
View reviewed changes
build/functions/failed-hook-installs.js Outdated

module.exports = function() {
const unusedHookInstalls = []
Object.keys(process.build.hooks).forEach(hook => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use .filter(hook => !process.build.hooks[hook].replaced) instead - it will return an array of the unprocessed hooks

calebcurtis8
calebcurtis8 suggested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@calebcurtis8 calebcurtis8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor the .forEach into .filter as marked

@calebcurtis8 calebcurtis8 merged commit 9a5f5ed into main Mar 16, 2023
@calebcurtis8 calebcurtis8 deleted the ob/hook-errors branch March 23, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcurtis8 calebcurtis8 calebcurtis8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsanolive @calebcurtis8