Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action should fail with an error if the files: settings are not valid #383

Closed
rpdelaney opened this issue Sep 11, 2023 · 0 comments 路 Fixed by #384
Closed

The action should fail with an error if the files: settings are not valid #383

rpdelaney opened this issue Sep 11, 2023 · 0 comments 路 Fixed by #384

Comments

@rpdelaney
Copy link
Contributor

Example: https://github.com/rpdelaney/downforeveryone/actions/runs/6149726050/job/16686210047

馃 dist/downforeveryone*.whl,dist/downforeveryone*.tar.gz not include valid file.

Instead of simply failing, this workflow run instead published a release with all the files in the repo: https://github.com/rpdelaney/downforeveryone/releases/tag/v1.0.5

This is a significant issue because it hides the fact that the action is not doing what the user expected and ends with success. The warnings are buried in the folds so I did not discover the problem until the release archive was already out there and downloaded.

rpdelaney added a commit to rpdelaney/action-gh-release that referenced this issue Sep 11, 2023
rpdelaney added a commit to rpdelaney/action-gh-release that referenced this issue Sep 11, 2023
softprops pushed a commit that referenced this issue Mar 8, 2024
* Change 'pattern does not match any files' warning to fatal

Fixes #383

* Raise a fatal error if the config file is not valid

Related to #383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant