Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload faling on windows-latest with EBUSY #51

Open
lostbean opened this issue May 18, 2020 · 4 comments
Open

Upload faling on windows-latest with EBUSY #51

lostbean opened this issue May 18, 2020 · 4 comments
Labels

Comments

@lostbean
Copy link

I'm using this action to release binaries from a matrix CI workflow building on macOS, linux and windows. The windows job is failing with the following error:
EBUSY: resource busy or locked, lstat 'D:\pagefile.sys'
image

The other two are working just fine. Is action-gh-release supported on a windows build?

@softprops
Copy link
Owner

It looks like you are trying to include all files at the root of your file system with/*. This is likely not what you want. You could try a relative path. This should be relative to the working directory of your checkout.

@lostbean
Copy link
Author

Thanks for sharing this awesome GH Action @softprops!

Oh that is definitely not what I want. The workflow is defined exactly like this:

    - name: Setup env
      run: |
        echo ::set-env name=OUTPUT_DIR::$(make show-output-dir)
    - name: Release cli
      if: startsWith(github.ref, 'refs/tags/')
      uses: softprops/action-gh-release@v1
      with:
        files: ${{ env.OUTPUT_DIR }}/*
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Where OUTPUT_DIR is the relative path of the output folder. This exact workflow works on macOS and linux. Maybe something related to the use of environment variables being broken in the Windows setup. It seems the variable was properly set:
image

Could it be the env is not being passed down to the action code? I'm not sure at which point the context ${{ env.OUTPUT_DIR }} is resolved.

@softprops
Copy link
Owner

softprops commented May 19, 2020

Could it be the env is not being passed down to the action code?

That would be my theory. I don't think env gets inherited between steps by default

I'd try some experiments like setting it explicitly

Or adding a debug step in between

with:
      files: ${{ env.OUTPUT_DIR }}/*
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        OUTPUT_DIR: ${{ env.OUTPUT_DIR }}

@softprops
Copy link
Owner

The docs say it should be available https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable

Either way I'd run some experiments to see if there's a way to be more explicit and work backwards to implicit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants