Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning #266

Closed

Conversation

alexevanczuk
Copy link

@alexevanczuk alexevanczuk commented Oct 15, 2022

Summary

Fixes #265 to prevent deprecation warnings in user consoles:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The recommended approach in the blog post is to upgrade @actions/core to 1.10.0.

When I ran npm install, I got this,

npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
(################⠂⠂) ⠧ idealTree:inflate:node_modules/assert-plus: sill inflate node_modules/assert-plus

I believe this is the cause of the large change in package-lock.json.

I tested this locally (by pointing another project at my fork) and verified it removes the deprecation warning.

Commits

  • Bump @actions/core to 1.10.0
  • npm install

@alexevanczuk
Copy link
Author

@softprops Let me know if you'd have time to review and merge this change. If not, I'll close this PR.

@jepler
Copy link

jepler commented Oct 23, 2022

Hi! At @adafruit we use this action. Please let us know if we can help get this PR accepted.

@alexevanczuk
Copy link
Author

Hey folks I'm going to close this out for now. We can always reopen it up and merge it.

In the meantime, I'll recommend two alternative approaches:

@DavidWiseman
Copy link

Hey folks I'm going to close this out for now. We can always reopen it up and merge it.

In the meantime, I'll recommend two alternative approaches:

Thanks. I've decided to replace with GH CLI.

@jepler
Copy link

jepler commented Oct 31, 2022

@tekktrik we should investigate the above options for library actions

casperdcl added a commit to iterative/shtab that referenced this pull request Nov 18, 2022
casperdcl added a commit to iterative/shtab that referenced this pull request Nov 18, 2022
casperdcl added a commit to AMYPAD/CuVec that referenced this pull request Nov 18, 2022
casperdcl added a commit to AMYPAD/CuVec that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the set-output command (deprecation warning)
3 participants