Add id input to support publish updates #357
Conversation
`files.length == 0` means the input was empty, so including it in the message just added confusing whitespace, as well as broke the grammar of the sentence.
| })) { | ||
| let release = response.data.find((release) => release.tag_name === tag); | ||
| if (release) { | ||
| return release; |
There was a problem hiding this comment.
This was super duper confusing to me. It seemed like, if you came through to find a draft release (because draft:true), you'd just return out from here when found, skipping all the logic below to update any of its fields. This means updating an existing draft release could only ever upload assets, it could not make any other changes. I don't know why you would want this and my PR changes this behavior. Now, if an existing release is found (no matter how) it is updated.
|
👋 ping on this. Is this action still maintained, or should we look elsewhere / consider maintaining our fork? It would be a shame, as this action appears to be the best alternative listed for the now-deprecated "official" release actions. |
|
Closing. We're going to just maintain and use our fork. |
It's currently not possible to publish a release (update
draftfromtruetofalse) through this action. That's because the action can only locate a draft Release to update if it iterates over them all, and it only does that ifdraftistrue, which means it can't also befalseto perform the desired update.To get around this, I added an
idinput and used that to find the existing release when given. This means you can pass the output of running the action once (to create the release) as an input to running the action again (to publish it) and it will be found and updated correctly.I also made it possible to omit
tag_namewhenidis given, and re-use the existing release's. This makes so everything is optional if you're trying to update an existing release byid, which ensures you can update what you want and retain all other values as whatever they were.