Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use target specific dependencies. #11

Merged
merged 1 commit into from Jan 14, 2017
Merged

Use target specific dependencies. #11

merged 1 commit into from Jan 14, 2017

Conversation

BurntSushi
Copy link
Contributor

This commit changes the Cargo.toml to require winapi and kernel32 only
on Windows builds, and requires libc for all other builds.

@BurntSushi
Copy link
Contributor Author

Note that this also bumps the Rust version in CI from 1.6 to 1.8, since 1.8 is required to parse target specific dependencies. You may want to increase the minor version on the next release because of this.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f6a328f on BurntSushi:windows-only-deps into ** on softprops:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f6a328f on BurntSushi:windows-only-deps into ** on softprops:master**.

@BurntSushi
Copy link
Contributor Author

A few interesting things to note:

  1. Mark platform-specific dependencies #7 and Conditionally depend on Windows and Unix libraries. #9 both purport to solve this problem, but I think this PR is the only one that bumps the minimum version and sets up the target specific dependencies correctly.
  2. All three PRs are failing on the Mac build. It's not clear why. If I run the tests locally on my Mac, then they pass.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 27bdf5f on BurntSushi:windows-only-deps into ** on softprops:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 27bdf5f on BurntSushi:windows-only-deps into ** on softprops:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6507d36 on BurntSushi:windows-only-deps into ** on softprops:master**.

@BurntSushi BurntSushi force-pushed the windows-only-deps branch 2 times, most recently from f0b3ecd to ccdc50c Compare January 8, 2017 03:53
@coveralls
Copy link

coveralls commented Jan 8, 2017 •
edited

Coverage Status

Changes Unknown when pulling ccdc50c on BurntSushi:windows-only-deps into ** on softprops:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a9b0e4a on BurntSushi:windows-only-deps into ** on softprops:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a9b0e4a on BurntSushi:windows-only-deps into ** on softprops:master**.

@BurntSushi BurntSushi mentioned this pull request Jan 8, 2017
Merged
@coveralls
Copy link

coveralls commented Jan 8, 2017 •
edited

Coverage Status

Changes Unknown when pulling 8d1354c on BurntSushi:windows-only-deps into ** on softprops:master**.

@BurntSushi
Use target specific dependencies.
bcb96e4 
This commit changes the Cargo.toml to require winapi and kernel32 only
on Windows builds, and requires libc for all other builds.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bcb96e4 on BurntSushi:windows-only-deps into ** on softprops:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bcb96e4 on BurntSushi:windows-only-deps into ** on softprops:master**.

@BurntSushi
Copy link
Contributor Author

OK, I "fixed" the broken test on darwin by simply testing for the opposite result. I'm not sure what caused the change in behavior, but I tested it locally and everything seems kosher.

@BurntSushi
Copy link
Contributor Author

@softprops Anything I can do to help get these merged? :-)

@softprops softprops merged commit ca2ab17 into softprops:master Jan 14, 2017
@softprops
Copy link
Owner

Done. I'll publish the new version tomorrow. Thanks!

This was referenced Jan 14, 2017
Closed
Closed
@BurntSushi BurntSushi deleted the windows-only-deps branch January 14, 2017 04:52
@softprops
Copy link
Owner

published https://crates.io/crates/atty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BurntSushi @coveralls @softprops