Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all elements of IssueOptions be Options #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hrothen
Copy link

@Hrothen Hrothen commented Jul 5, 2016

This is a breaking change, should this PR also update the project version?

All parameters for the api endpoint are optional
@dwijnand
Copy link
Contributor

dwijnand commented Jan 6, 2019

Hmm, this PR is quite old and a little bit stale too (syntex is no longer used and filenames have changed).

Also, I wonder if the objective here (making issue title and labels optional) could be approximated without breaking the API, i.e with an empty string and an empty Vec (which I don't think carry a distinct meaning).

@Hrothen how interested are you in this change landing?

@Hrothen
Copy link
Author

Hrothen commented Jan 6, 2019

Not at all, this PR is 2 and a half years old, I've moved on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants