Dependency segmentation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent and thank you! |
|
Sorry, I did not push a formatting commit. I will open another PR to fix the formatting errors ASAP. It will also include some documentation updates and clippy checks. |
edmorley
added a commit
to edmorley/hyperlocal
that referenced
this pull request
Feb 26, 2022
Adds documentation for the switch to the `client` and `server` features now being opt-in, rather than enabled by default (see softprops#54). I experimented with also enabling the nightly-only `doc_cfg` / `doc_auto_cfg` features (see rust-lang/rust/issues/43781, which can be used on `docs.rs` since it builds docs with nightly), however: - the features don't currently work well with the re-exports in the crate root, so require every struct/trait to be manually annotated. - the rendering isn't great - the crate landing page wrapping ended up broken So for now it seems best to not use that. I did adjust the `docs.rs` config in `Cargo.toml` to ensure docs are actually generated for all features, since previously the docs were almost empty. I also fixed a few typos / markdown syntax errors.
edmorley
added a commit
to edmorley/hyperlocal
that referenced
this pull request
Feb 26, 2022
Adds documentation for the switch to the `client` and `server` features now being opt-in, rather than enabled by default (see softprops#54). I experimented with also enabling the nightly-only `doc_cfg` / `doc_auto_cfg` features (see rust-lang/rust/issues/43781, which can be used on `docs.rs` since it builds docs with nightly), however: - the features don't currently work well with the re-exports in the crate root, so require every struct/trait to be manually annotated. - the rendering isn't great - the crate landing page wrapping ended up broken So for now it seems best to not use that. I did adjust the `docs.rs` config in `Cargo.toml` to ensure docs are actually generated for all features, since previously the docs were almost empty. I also fixed a few typos / markdown syntax errors.
edmorley
added a commit
to edmorley/bollard
that referenced
this pull request
Feb 28, 2022
This is another small step towards reducing the size of bollard's dependency tree :-) `tokio` and `hyper` have both switched from `pin-project` crate to the lighter-weight `pin-project-lite`: tokio-rs/tokio#1778 hyperium/hyper#2566 This does the same for bollard. For the differences between the two crates, see: https://docs.rs/pin-project-lite/0.2.8/pin_project_lite/#pin-project-vs-pin-project-lite Note: The full advantage of this won't be seen until a new `hyperlocal` release exists that contains: softprops/hyperlocal#54 ...and bollard updates to that release, so that `pin-project` can be fully dropped from the dependency tree.
|
@softprops Hi! I don't suppose you know when you might have a spare moment to look at #58 / #57 so a new version of |
edmorley
added a commit
to edmorley/bollard
that referenced
this pull request
Mar 6, 2022
Tokio offers the following features: https://docs.rs/tokio/latest/tokio/#feature-flags This removes the following unused Tokio features from `dependencies`: - `fs`: Since it's only used by examples/tests/doctests: https://github.com/fussybeaver/bollard/search?q=%22tokio%3A%3Afs%22 - `rt` / `rt-multi-thread`: Since it's not used by bollard itself, and should be specified by end-users in their application. By activating `rt-multi-thread` by default, it means anyone not using the multi-thread runtime has to pay the dependency/compile time price for it regardless. And the following from `dev-dependencies`: - `time` / `net`: Since they are already specified in `dependencies`, and it's not necessary to duplicate them in `dev-dependencies` as Cargo will perform feature unification. - `rt`: Since `rt-multi-thread` includes `rt` already. - `io-std`: Since it's not used by any examples/tests and isn't even one of the official top-level features anyway: https://docs.rs/tokio/latest/tokio/#feature-flags Note: The full benefits of this change won't be realised until this `hyperlocal` change is picked up in the next `hyperlocal` release: softprops/hyperlocal#54
edmorley
added a commit
to edmorley/bollard
that referenced
this pull request
Mar 8, 2022
Tokio offers the following features: https://docs.rs/tokio/latest/tokio/#feature-flags This removes the following unused Tokio features from `dependencies`: - `fs`: Since it's only used by examples/tests/doctests: https://github.com/fussybeaver/bollard/search?q=%22tokio%3A%3Afs%22 - `rt` / `rt-multi-thread`: Since it's not used by bollard itself, and should be specified by end-users in their application. By activating `rt-multi-thread` by default, it means anyone not using the multi-thread runtime has to pay the dependency/compile time price for it regardless. And the following from `dev-dependencies`: - `time` / `net`: Since they are already specified in `dependencies`, and it's not necessary to duplicate them in `dev-dependencies` as Cargo will perform feature unification. - `rt`: Since `rt-multi-thread` includes `rt` already. - `io-std`: Since it's not used by any examples/tests and isn't even one of the official top-level features anyway: https://docs.rs/tokio/latest/tokio/#feature-flags Note: The full benefits of this change won't be realised until this `hyperlocal` change is picked up in the next `hyperlocal` release: softprops/hyperlocal#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is technically comprised of three changes. Since the changes are small individually, they are bundled together here. I can split the changes into separate PRs if that is preferred.
The main motivation of this PR is to segment
hyper's server and client features intohyperlocal's server and client features.This helps reduce compile times for dependents only needing one of the features. To further reduce compile times, this PR also exchanges
pin-projectforpin-project-liteand removes thefutures-utildependency:pin-project-liteis used overpin-projectintokio, and Ruststd::futureis now standard enough to accomplish what is included fromfutures-util.Some basic timings (
cargo cleanbefore each run):cargo build --no-default-features --features=clientcargo build --no-default-features --features=servercargo build --all-features