Disable Hyper's http protocol enforcement. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some situations where the Docker daemon will expose a HTTP server and will expect connections through a TCP connection rather than via a unix socket. For example, this is the case with Docker for Windows when used through the Windows Subsystem for Linux. In these cases, `DOCKER_HOST` will be of the form `tcp://127.0.0.1:2375`. Docker will not work if `DOCKER_HOST` has the `http` protocol. This commit manually builds a `HttpConnector` from Hyper so that it does not fail if the protocol is not `http`. Therefore, the `DOCKER_HOST` that works with Docker will also work with shiplift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome crate! I was having some issues using with Docker for Windows (in combination with the Windows Subsystem for Linux) and this PR fixes that. Happy to make any adjustments that are required.
What did you implement:
This PR manually builds a
HttpConnectorfrom Hyper so that it does not fail if the protocol is nothttp. Therefore,DOCKER_HOSTof the formtcp://127.0.0.1:2375will work with shiplift.Closes: N/A
How did you verify your change:
Tested with the project I'm working on where this was failing previously.
What (if anything) would need to be called out in the CHANGELOG for the next release:
N/A