Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanative sentence for volumes option #164

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
3 participants
@keirlawson
Copy link
Contributor

commented Apr 26, 2019

What did you implement:

Added a documentation for the volumes option.

Closes: #163

How did you verify your change:

Generated documentation locally

@softprops

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

Thanks @keirlawson

@softprops softprops merged commit bc732d8 into softprops:master Apr 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -564,6 +564,7 @@ impl ContainerOptionsBuilder {
self
}

/// Specify any bind mounts, taking the form of `/some/host/path:/some/container/path`

This comment has been minimized.

Copy link
@schrieveslaach

schrieveslaach Apr 26, 2019

Contributor

I think volumes is not restricted to bind mounts. You can use also use named volumes. For example, you could use volumes(vec!["myvol2:/app"]) (see here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.