Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing process env variables for IP and PORT #567

Closed
alejandrosaenz117 opened this issue Jan 27, 2021 · 0 comments
Closed

Missing process env variables for IP and PORT #567

alejandrosaenz117 opened this issue Jan 27, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@alejandrosaenz117
Copy link
Collaborator

Our default .env instructions are missing the IP and PORT variables which is causing the application to revert to localhost and port 5000.

This ticket is to add this process env variables and test the application with different IP and PORT.

Please see #565 for more information.
@alejandrosaenz117 alejandrosaenz117 added the bug Something isn't working label Jan 27, 2021
alejandrosaenz117 added a commit that referenced this issue Jan 28, 2021
@alejandrosaenz117
fix(package.json): updated package.json script
3e201eb 
Updated package.jsons script to include dynamic IP and Port settings in angular

BREAKING CHANGE: Added additional process env variables.  Puppeteer functionality has been updated
to use these new process env variables.

fix #567
alejandrosaenz117 added a commit that referenced this issue Jan 28, 2021
@alejandrosaenz117
build(.gitignore): delete generated angular env files
3be81a2 
fix #567
alejandrosaenz117 added a commit that referenced this issue Jan 28, 2021
@alejandrosaenz117
fix(frontend/package.json): update script to use different angular envv
8c2481e 
Updated package.json and angular.json to utilize production and development envs

fix #567
alejandrosaenz117 added a commit that referenced this issue Jan 29, 2021
@alejandrosaenz117
chore(setenv.ts): update console.info and documentation
3aa0e94 
Update console.info so it's more clear to user that the script is being skipped by docker. Updated
README.

chore #567
@alejandrosaenz117 alejandrosaenz117 mentioned this issue Jan 29, 2021
Merged
18 tasks
alejandrosaenz117 added a commit that referenced this issue Jan 29, 2021
@alejandrosaenz117
chore(merge conflicts): fix merge conflicts
a431af0 
chore #567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alejandrosaenz117