Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fix csp errors): cSP errors were generated in console #566

Merged
merged 3 commits into from
Jan 29, 2021

Conversation

waterweasel4
Copy link
Contributor

Pull Request

Thank you for your contribution to the Bulwark. Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #565

Type of change

  • A new feature
  • A bug fix
  • Documentation only changes
  • Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • A code change that neither fixes a bug nor adds a feature
  • A code change that improves performance
  • Adding missing tests or correcting existing tests
  • Changes that affect the build system or external dependencies
  • Changes to our CI configuration files and scripts
  • Other changes that don't modify src or test files

Add description here


I think that the CSP errors are fixed now.  When I tested locally, I cannot reproduce any longer.  

Checklist

  • My code follows the contributing guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

waterweasel4 and others added 2 commits January 26, 2021 16:27
CSP errors were generated in the console when the URL didn't match what the /api/login said.

fix565
Fixing the CSP errors by moving around helmet code

fix #566
@waterweasel4
Copy link
Contributor Author

Moved app.use(helmet()); up in the code a bit.

Fixing the CSP errors, moving the helmet code around

fix #566
@alejandrosaenz117 alejandrosaenz117 merged commit ff8614d into develop Jan 29, 2021
@waterweasel4 waterweasel4 deleted the csp branch June 23, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants