fix: honor report size in dmarc URI

[shaunwarman]

Taking a stab at #2

Honor the report size in dmarc URI (e.g. ... rua=some@email.com!30m) before validating the email.

closes #2

[coveralls]

Coverage increased (+0.6%) to 95.181% when pulling 52036d7 on shaunwarman:honor-report-size into 14f4789 on softvu:master.

[niftylettuce]

I think it may need more than just splitting by ! as ! is a valid character in email addresses.

> require('validator').isEmail('word!up@wordup.co')
true

[shaunwarman]

Oh duh, good catch

[c0bra]

I no longer work at the company that needed this library, so my brain is probably missing vital relevant bits, but maybe we could do matching like:

const limitRE = /!(?<limit>.+)$/
const limitMatch = email.match(limitRE)

if (limitMatch) {
  const sizeLimit = limitMatch.groups.limit
  email = email.replace(limitRE, '')
}

[niftylettuce]

Thank you @c0bra - @shaunwarman will get this resolved soon and push up so you can release new version to npm once merged. We are using this for @forwardemail

[shaunwarman]

Sorry for the hold up @c0bra - just got back to this. Thanks for that match!

[c0bra]

👍

[c0bra]

Published just now in v1.2.0

[niftylettuce]

This does not support email addresses with exclamation marks. I've opened PR #10 to fix this @c0bra. Could you please merge it and publish a new version then? Also note that I've filed issue #9 due to size and numbers still not being validated in the !10m portion. We need to add validation to that so it's true to spec as well.

Thank you! 🙏

Ref:

• <https://github.com/domainaware/checkdmarc/blob/master/checkdmarc.py#L1108-L1140
• https://github.com/trailofbits/dmarc/blob/554bd015745d6e5f51cbce01608c6659aa1db96b/lib/dmarc/uri.rb