Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisitableView: introduce webViewDebuggingEnabled property #196

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

pklatka
Copy link
Collaborator

@pklatka pklatka commented Apr 26, 2024

Summary

This PR:

  1. Introduces webViewDebuggingEnabled property on VisitableView to enable the remote debugging using Safari / Chrome. Now remote debugging is disabled by default, but can be enabled by setting the property to true.
  2. Changes the place of calling the visit() function in RNVisitableView.swift. Now the visit() function is called in didSetProps to make sure that all props are being initialized. Without that change, somehow url didSet is called before sessionHandle which causes the WKWebView not to mount.

Test plan

Tested on iOS and Android using the example app.

@pklatka pklatka merged commit fc99a69 into main Apr 26, 2024
1 check passed
@pklatka pklatka deleted the webview-debug branch April 26, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant