VisitableView: introduce webViewDebuggingEnabled
property
#196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
webViewDebuggingEnabled
property onVisitableView
to enable the remote debugging using Safari / Chrome. Now remote debugging is disabled by default, but can be enabled by setting the property totrue
.visit()
function inRNVisitableView.swift
. Now thevisit()
function is called indidSetProps
to make sure that all props are being initialized. Without that change, somehow urldidSet
is called beforesessionHandle
which causes the WKWebView not to mount.Test plan
Tested on iOS and Android using the example app.