Add support for alert and confirm
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeiffer
reviewed
Dec 12, 2023
mironiasty
force-pushed
the
add-support-for-alert-ios
branch
from
fd451ca
to
09b2d5c
Compare
mironiasty
requested review from
pfeiffer,
sebryu and
pklatka
and removed request for
pfeiffer
pfeiffer
approved these changes
Dec 12, 2023
pklatka
approved these changes
Dec 13, 2023
packages/turbo/android/src/main/java/com/reactnativeturbowebview/RNWebChromeClient.kt
Outdated
Show resolved
Hide resolved
packages/turbo/android/src/main/java/com/reactnativeturbowebview/RNWebChromeClient.kt
Outdated
Show resolved
Hide resolved
packages/turbo/android/src/main/java/com/reactnativeturbowebview/RNWebChromeClient.kt
Outdated
Show resolved
Hide resolved
packages/turbo/android/src/main/java/com/reactnativeturbowebview/RNVisitableView.kt
Outdated
Show resolved
Hide resolved
| let session = Session(webViewConfiguration: webViewConfiguration) | ||
| session.delegate = self | ||
| session.webView.allowsLinkPreview = false | ||
| session.webView.uiDelegate = self.wkUiDelegate |
There was a problem hiding this comment.
Maybe let's remove wkUiDelegate variable and set TurboUIDelegate(uiHandler: self) here? We don't use self.wkUiDelegate anywhere.
There was a problem hiding this comment.
I did it because uiDelegate is weak property. Is there better way of making it correct in swift? 🤔
There was a problem hiding this comment.
I did it because uiDelegate is weak property.
You're right, let's leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new props to VisitableView to support web
alertandconfirmdialogs.There is also default support for both (that was missing before). So both
alertandconfirmwill now work as React Native'sAlert.alertcall.