Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WebView debugging #77

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Enable WebView debugging #77

merged 1 commit into from
Dec 13, 2023

Conversation

pklatka
Copy link
Collaborator

@pklatka pklatka commented Dec 12, 2023 •
edited
Loading

Summary

This PR enables debugging the WebView when app is in a DEBUG mode.

mironiasty
mironiasty reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@mironiasty mironiasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can always enable debugging webview when app is in debugging mode (and remove webviewDebuggingEnabled from VisitableView).

This API makes it easy to set debugging enabled for production builds, which might not be desired option.

packages/turbo/src/VisitableView.tsx Outdated Show resolved Hide resolved
@pklatka pklatka changed the title Add webviewDebuggingEnabled property Enable WebView debugging Dec 13, 2023
mironiasty
mironiasty approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@mironiasty mironiasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pklatka pklatka merged commit 91d573b into main Dec 13, 2023
1 check passed
@pklatka pklatka deleted the @pklatka/debug branch December 19, 2023 21:19
@krschacht krschacht mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mironiasty mironiasty mironiasty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pklatka @mironiasty