Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop printing redirect URL #11

Closed
1 task done
mkaput opened this issue Aug 17, 2023 · 5 comments
Closed
1 task done

Stop printing redirect URL #11

mkaput opened this issue Aug 17, 2023 · 5 comments
Assignees
@gaetbout
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mkaput
Copy link
Member

mkaput commented Aug 17, 2023 •
edited
Loading

Problem

It happens that we break output from some commands by printing the redirect URL 😱 I think it'd be the easiest if we drop it entirely, but we would very appreciate it if it could be conditionally printed during normal installation.

Steps

$ asdf latest --all
elixir	main-otp-26	missing
erlang	26.0.2	missing
nodejs	20.5.1	missing
python	stackless-3.7.5	missing
ruby	truffleruby+graalvm-23.0.0	missing
redirect url: https://github.com/software-mansion/scarb/releases/tag/v0.6.2
scarb	0.6.2	installed
terraform	1.5.5	missing

Possible Solution(s)

No response

Notes

Please leave a comment that you are willing to contribute a PR fixing this issue before starting doing so, in order to avoid having two people working on this independently 😄

Does this issue reproduce in the latest version of asdf-scarb?

  • Yes, it does.
@mkaput mkaput added bug Something isn't working good first issue Good for newcomers labels Aug 17, 2023
@gaetbout
Copy link
Contributor

Can I try this one?

@mkaput
Copy link
Member Author

mkaput commented Aug 17, 2023

Sure, go on, but perhaps wait for #10 to be merged :)

@gaetbout
Copy link
Contributor

I subscribed to #10, I'll wait then :)

@gaetbout
Copy link
Contributor

can you elaborate on what is a "normal installation"?

@mkaput
Copy link
Member Author

mkaput commented Aug 18, 2023 •
edited
Loading

can you elaborate on what is a "normal installation"?

OK, so I think it'd be still awesome if we have a possibility to tell users what version is going to be installed when they type one of the following:

asdf install scarb latest
asdf install scarb latest:nightly
asdf local scarb latest
asdf global scarb latest

etc. These commands are what I meant by normal installation; sorry for mental shortcut.

This was the original purpose of printing that URL. It was just a poor man solution.

@gaetbout gaetbout mentioned this issue Aug 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 23, 2023
@gaetbout
Removing redirect url (#13)
0a15fc4 
After looking in the (thin) ASDF documentation I couldn't find any way
to tell the bash script when an installation is from asdf or not 🙁

Hope this solves issue #11
@mkaput mkaput closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaetbout gaetbout

Labels
bug Something isn't working good first issue Good for newcomers
Projects
Scarb
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkaput @gaetbout