Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize outputs in CLI #2107

Closed
THenry14 opened this issue Jun 22, 2023 · 1 comment · Fixed by #2135
Closed

Normalize outputs in CLI #2107

THenry14 opened this issue Jun 22, 2023 · 1 comment · Fixed by #2135
Assignees
@war-in
Milestone
CLI in Rust

Comments

@THenry14
Copy link
Member

THenry14 commented Jun 22, 2023 •
edited

We should decide on one approach to outputting information to users, and apply it (Felts, Ints, formatting etc).

Suggestions:
https://docs.rs/console/latest/console/
https://docs.rs/color-eyre/latest/color_eyre/

We could take a look at what scarb is using, and try to conform to that.
@THenry14 THenry14 added this to the CLI in Rust milestone Jun 22, 2023
@THenry14 THenry14 mentioned this issue Jun 22, 2023
Merged
3 tasks
@cptartur cptartur mentioned this issue Jun 22, 2023
Merged
3 tasks
@war-in war-in self-assigned this Jun 26, 2023
@piotmag769
Copy link
Contributor

I would also emphasise on the need of returning non-zero exit code on failure - it will be useful in scripts and that's what we do in test runner as well.
cc @THenry14 @war-in

@war-in war-in mentioned this issue Jun 27, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 29, 2023
@war-in
Normalize outputs in CLI (#2135)
a0e57ad 
Closes #2107 

### Checklist
- [x] Relevant issue is linked
- [ ] Docs updated/issue for docs created
- [ ] Added relevant tests
@THenry14 THenry14 mentioned this issue Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@war-in war-in

Labels
None yet
Projects
None yet
Milestone
CLI in Rust
Development

Successfully merging a pull request may close this issue.

Normalize outputs in CLI software-mansion/protostar
3 participants
@THenry14 @piotmag769 @war-in