[project_class_refactor::03] Replace old code in `init`. Refactor `init`. #364

kasperski95 · 2022-06-14T12:00:58Z

connected protostar_toml to init
refactored init

mark as ready to review once ::02 is merged

…into refactor/project-to-protostar-toml

…om/software-mansion/protostar into refactor/add-tests-to-protostar-toml

codecov · 2022-06-14T13:07:15Z

Codecov Report

Merging #364 (aeb53ff) into master (b9b74f6) will increase coverage by 0.36%.
The diff coverage is 63.50%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   83.99%   84.36%   +0.36%     
==========================================
  Files         108      113       +5     
  Lines        3868     3920      +52     
==========================================
+ Hits         3249     3307      +58     
+ Misses        619      613       -6

Impacted Files	Coverage Δ
protostar/protostar_cli_test.py	`95.34% <ø> (ø)`
protostar/commands/init/init_command.py	`71.79% <47.61%> (+27.79%)`	⬆️
...mmands/init/project_creator/new_project_creator.py	`52.77% <52.77%> (ø)`
protostar/utils/requester.py	`53.84% <53.84%> (ø)`
...ds/init/project_creator/adapted_project_creator.py	`62.50% <62.50%> (ø)`
.../commands/init/project_creator/_project_creator.py	`81.81% <81.81%> (ø)`
protostar/commands/__init__.py	`100.00% <100.00%> (ø)`
protostar/commands/init/__init__.py	`100.00% <100.00%> (ø)`
...rotostar/commands/init/project_creator/__init__.py	`100.00% <100.00%> (ø)`
protostar/protostar_cli.py	`98.24% <100.00%> (+0.16%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b74f6...aeb53ff. Read the comment docs.

…into refactor/add-tests-to-protostar-toml

….com/software-mansion/protostar into refactor/integrate-protostar-toml

…into refactor/add-tests-to-protostar-toml

….com/software-mansion/protostar into refactor/integrate-protostar-toml

…into refactor/integrate-protostar-toml

MaksymilianDemitraszek

It's generaly very good, I like the way you implemented it. Some minor comments please addres them before merging

protostar/utils/requester.py

protostar/commands/init/project_creator/_project_creator.py

protostar/commands/init/init_command.py

Bumps [pytest-mock](https://github.com/pytest-dev/pytest-mock) from 3.10.0 to 3.11.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/releases">pytest-mock's releases</a>.</em></p> <blockquote> <h2>v3.11.1</h2> <ul> <li> <p>Fixed introspection for failed <code>assert_has_calls</code> (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>).</p> </li> <li> <p>Updated type annotations for <code>mocker.patch</code> and <code>mocker.spy</code> (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>).</p> </li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-mock/blob/main/CHANGELOG.rst">pytest-mock's changelog</a>.</em></p> <blockquote> <h2>3.11.1 (2023-06-15)</h2> <p>(This release source code is identical to <code>3.11.0</code> except a small internal fix to deployment/CI)</p> <ul> <li> <p>Fixed introspection for failed <code>assert_has_calls</code> (<code>[#365](https://github.com/pytest-dev/pytest-mock/issues/365)</code>_).</p> </li> <li> <p>Updated type annotations for <code>mocker.patch</code> and <code>mocker.spy</code> (<code>[#364](https://github.com/pytest-dev/pytest-mock/issues/364)</code>_).</p> </li> </ul> <p>.. _<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>: <a href="https://redirect.github.com/pytest-dev/pytest-mock/pull/365">pytest-dev/pytest-mock#365</a> .. _<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>: <a href="https://redirect.github.com/pytest-dev/pytest-mock/pull/364">pytest-dev/pytest-mock#364</a></p> <h2>3.11.0 (2023-06-15)</h2> <ul> <li> <p>Fixed introspection for failed <code>assert_has_calls</code> (<code>[#365](https://github.com/pytest-dev/pytest-mock/issues/365)</code>_).</p> </li> <li> <p>Updated type annotations for <code>mocker.patch</code> and <code>mocker.spy</code> (<code>[#364](https://github.com/pytest-dev/pytest-mock/issues/364)</code>_).</p> </li> </ul> <p>.. _<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>: <a href="https://redirect.github.com/pytest-dev/pytest-mock/pull/365">pytest-dev/pytest-mock#365</a> .. _<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>: <a href="https://redirect.github.com/pytest-dev/pytest-mock/pull/364">pytest-dev/pytest-mock#364</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/d3e73f2e93f7b93eba0a36e17e43bafd969da4fe"><code>d3e73f2</code></a> Explicitly specify the tag name during GitHub Release</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/5668efe23e01673af9905febeefd9a9791b023f4"><code>5668efe</code></a> Update CHANGELOG for 3.11.0</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/c9a4d13ab4e808ef02250898a79c07b2acf76f61"><code>c9a4d13</code></a> Improve CI</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/5818160717a16b7f8867d950ed60b9dc3349ec8d"><code>5818160</code></a> Add assert_has_calls_wrapper (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/365">#365</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/355b5aae1a1a9b3f2c17b2a6bbfde9980967bceb"><code>355b5aa</code></a> Fix return type annotation for patch and spy (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/364">#364</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/8ba681201488bec69f27f6e9e2a56988a01f0d1b"><code>8ba6812</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/362">#362</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/786eaaf416fed8204a8aebb29cbf71527228a9f6"><code>786eaaf</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/360">#360</a>)</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/1cb146af21ffd0b5be24703419cf4a192c4ec0ab"><code>1cb146a</code></a> Push tag manually</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/9608e9659b1f062bb09915f3ef1c538ca7cb5c5f"><code>9608e96</code></a> Update permissions for deploy workflow</li> <li><a href="https://github.com/pytest-dev/pytest-mock/commit/c778ee73bd516d465dca3512d099682ba32108fa"><code>c778ee7</code></a> Fix deployment workflow (<a href="https://redirect.github.com/pytest-dev/pytest-mock/issues/358">#358</a>)</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-mock/compare/v3.10.0...v3.11.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pytest-mock&package-manager=pip&previous-version=3.10.0&new-version=3.11.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

kasperski95 and others added 23 commits June 6, 2022 13:51

add protostar_toml

4c448cc

add types

7a99b74

move sections to separate files

05c141f

handle saving

9eae574

refactor

4892b24

refactor

b4a14d8

refactor

f0146f5

format

05865b0

format

2690f89

Merge branch 'master' of https://github.com/software-mansion/protostar …

2ab0793

…into refactor/project-to-protostar-toml

add test

808633b

rename type

5559060

Merge branch 'refactor/project-to-protostar-toml' of https://github.c…

946dc17

…om/software-mansion/protostar into refactor/add-tests-to-protostar-toml

add protostar_config_section_test

94afa27

add protostar_contracts_section_test

256d436

add protostar_project_section_test

d8d7c52

add protostar_toml_exceptions_test

c306ad2

add protostar_toml_reader_test

3d0a4e6

add protostar_toml_writer_test

da23754

add integration test

c494867

format

cf40ef2

use in init

bbbcf26

refactor init command

2aa5fee

kasperski95 changed the title ~~Refactor/integrate protostar toml~~ [project_class_refactor::03] Replace old code Jun 14, 2022

kasperski95 added 3 commits June 14, 2022 14:07

revert build_project changes

2d4f09b

lint

f860717

format

323ebf8

kasperski95 changed the title ~~[project_class_refactor::03] Replace old code~~ [project_class_refactor::03] Replace old code in init. Refactor init. Jun 14, 2022

kasperski95 self-assigned this Jun 14, 2022

kasperski95 marked this pull request as ready for review June 14, 2022 12:13

fix lib_path

1c13682

kasperski95 and others added 9 commits June 15, 2022 12:23

Merge branch 'master' of https://github.com/software-mansion/protostar …

b7ce85d

…into refactor/add-tests-to-protostar-toml

_add get_default

65a4a51

remove save_default

cd9f86f

convert mock_protostar_toml_reader to a fixture

a00f0ce

rename from... to load

f847aec

format

29ce97e

move reader and writer to io directory

f23e433

Merge branch 'refactor/add-tests-to-protostar-toml' of https://github…

8e5fb45

….com/software-mansion/protostar into refactor/integrate-protostar-toml

fix after pulling

03f6fd6

kasperski95 marked this pull request as draft June 17, 2022 08:57

kasperski95 added 5 commits June 17, 2022 13:08

make FlattenSectionName less cryptic

a550c50

make save static

2415e0c

mark as static method

fee6d1c

Merge branch 'master' of https://github.com/software-mansion/protostar …

5dcd080

…into refactor/add-tests-to-protostar-toml

Merge branch 'refactor/add-tests-to-protostar-toml' of https://github…

b2c930e

….com/software-mansion/protostar into refactor/integrate-protostar-toml

Base automatically changed from refactor/add-tests-to-protostar-toml to master June 17, 2022 14:34

Merge branch 'master' of https://github.com/software-mansion/protostar …

aeb53ff

…into refactor/integrate-protostar-toml

kasperski95 marked this pull request as ready for review June 17, 2022 14:35

kasperski95 requested a review from MaksymilianDemitraszek June 17, 2022 14:35

MaksymilianDemitraszek approved these changes Jun 21, 2022

View reviewed changes

protostar/utils/requester.py Show resolved Hide resolved

protostar/commands/init/project_creator/_project_creator.py Show resolved Hide resolved

protostar/commands/init/init_command.py Show resolved Hide resolved

kasperski95 merged commit 050683f into master Jun 21, 2022

kasperski95 deleted the refactor/integrate-protostar-toml branch June 21, 2022 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[project_class_refactor::03] Replace old code in `init`. Refactor `init`. #364

[project_class_refactor::03] Replace old code in `init`. Refactor `init`. #364

kasperski95 commented Jun 14, 2022 •

edited

codecov bot commented Jun 14, 2022 •

edited

MaksymilianDemitraszek left a comment

[project_class_refactor::03] Replace old code in init. Refactor init. #364

[project_class_refactor::03] Replace old code in init. Refactor init. #364

Conversation

kasperski95 commented Jun 14, 2022 • edited

codecov bot commented Jun 14, 2022 • edited

Codecov Report

MaksymilianDemitraszek left a comment

Choose a reason for hiding this comment

[project_class_refactor::03] Replace old code in `init`. Refactor `init`. #364

[project_class_refactor::03] Replace old code in `init`. Refactor `init`. #364

kasperski95 commented Jun 14, 2022 •

edited

codecov bot commented Jun 14, 2022 •

edited