Could not find root view for a given ancestor with tag #1675

federicot · 2021-10-07T13:06:57Z

Description

We are seeing the following crash on Android:

com.facebook.react.bridge.JSApplicationIllegalArgumentException: Could find root view for a given ancestor with tag 3199
    at com.swmansion.gesturehandler.react.RNGestureHandlerModule.tryInitializeHandlerForReactRootView(RNGestureHandlerModule.java:18)
    at com.swmansion.gesturehandler.react.RNGestureHandlerModule.attachGestureHandler(RNGestureHandlerModule.java:1)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:18)
    at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:2)
    at com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java)
    at android.os.Handler.handleCallback(Handler.java:869)
    at android.os.Handler.dispatchMessage(Handler.java:101)
    at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:1)
    at android.os.Looper.loop(Looper.java:206)
    at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:8)
    at java.lang.Thread.run(Thread.java:764)

Screenshots

Steps To Reproduce

I was not able to reproduce it consistently, but it seems to happen after the app goes to foreground.

Package versions

React: 17.0.1
React Native: >= 0.64.2
React Native Gesture Handler: 1.10.3
React Navigation: 5.14.4

The text was updated successfully, but these errors were encountered:

alexfov · 2021-10-13T20:29:13Z

I have the same problem in production.
"react-native": "0.65.1",
"react-native-gesture-handler": "1.9.0",
"@react-navigation/native": "5.8.10",

farafonoff · 2021-10-18T08:43:44Z

facing same issue
"react-native": "0.65.1",
"react-native-gesture-handler": "1.9.0"

sapramit · 2021-10-26T09:11:37Z

Any update on this one. occuring for me as well. Every time I try restarting the app programatically.

"react-native": "0.65.1",
"react-native-gesture-handler": "1.9.0" // Any version actually

jcdhlzq · 2021-10-29T03:40:52Z

we are also suffering from this problem reported by users online. EXPECTING a solution!

rdeift · 2021-11-02T14:28:08Z

+1

ThienNgn · 2021-11-04T09:11:41Z

+1

systemride · 2021-11-10T21:25:56Z

We are also seeing this with:

"react-native": "0.66.1",
"react-native-gesture-handler": "1.8.0",

aleksandr-senichev · 2021-11-16T15:39:50Z

+1

leofolive · 2021-11-18T23:29:55Z

+1

stephenkopylov · 2021-11-22T19:40:23Z

+1

com.facebook.react.bridge.JSApplicationIllegalArgumentException: Could find root view for a given ancestor with tag 6343
        at com.swmansion.gesturehandler.react.RNGestureHandlerModule.tryInitializeHandlerForReactRootView(RNGestureHandlerModule.java:18)
        at com.swmansion.gesturehandler.react.RNGestureHandlerModule.attachGestureHandler(RNGestureHandlerModule.java:1)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:18)
        at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:13)
        at com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java:-2)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:1)
        at android.os.Looper.loop(Looper.java:214)
        at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:8)
        at java.lang.Thread.run(Thread.java:919)

wemow · 2021-11-23T13:02:09Z

Same issue here too
"react-native": "0.66.1",
"react-native-gesture-handler": "^1.10.3",

anatooly · 2021-11-25T09:03:29Z

Same issue here too
"react-native": "0.66.1",
"react-native-gesture-handler": "^1.10.3",

systemride · 2021-11-25T18:20:13Z

This may not really be a fix, but we found a workaround for this that is working well for us. We are using:

"react-native": "0.66.1",
"react-native-gesture-handler": "1.8.0",

Remove the Override in MainActivity.java:

-  @Override
-  protected ReactActivityDelegate createReactActivityDelegate() {
-    return new ReactActivityDelegate(this, getMainComponentName()) {
-      @Override
-      protected ReactRootView createRootView() {
-       return new RNGestureHandlerEnabledRootView(MainActivity.this);
-      }
-    };
-  }

Add the GestureHandlerRootView to your app.

+ import { GestureHandlerRootView } from "react-native-gesture-handler";

...

+ <GestureHandlerRootView style={{ flex: 1 }}>
+   <App/>
+ </GestureHandlerRootView>

This step might not be necessary and probably not recommended by the library authors, but we also forked our own version and made the following changes to RNGestureHandlerModule.java:

- throw new JSApplicationIllegalArgumentException("Could find root view for a given ancestor with tag "
              + ancestorViewTag);

... and just return instead of throwing. Honestly we're not exactly sure of the ramifications of this, but the app seems to behave normally in this scenario.

+ return;

federicot · 2021-11-26T08:13:52Z

@systemride Thanks for sharing. Are you also using codepush?

wemow · 2021-11-26T14:39:45Z

This may not really be a fix, but we found a workaround for this that is working well for us. We are using:
"react-native": "0.66.1",
"react-native-gesture-handler": "1.8.0",
Remove the Override in MainActivity.java:
-  @Override
-  protected ReactActivityDelegate createReactActivityDelegate() {
-    return new ReactActivityDelegate(this, getMainComponentName()) {
-      @Override
-      protected ReactRootView createRootView() {
-       return new RNGestureHandlerEnabledRootView(MainActivity.this);
-      }
-    };
-  }
Add the GestureHandlerRootView to your app.
+ import { GestureHandlerRootView } from "react-native-gesture-handler";

...

+ <GestureHandlerRootView>
+   <App/>
+ </GestureHandlerRootView>
This step might not be necessary and probably not recommended by the library authors, but we also forked our own version and made the following changes to RNGestureHandlerModule.java:
- throw new JSApplicationIllegalArgumentException("Could find root view for a given ancestor with tag "
              + ancestorViewTag);
... and just return instead of throwing. Honestly we're not exactly sure of the ramifications of this, but the app seems to behave normally in this scenario.
+ return;

Well, unfortunately, your trick won't do for me, my app goes completely blank

systemride · 2021-11-26T18:49:36Z

Well, unfortunately, your trick won't do for me, my app goes completely blank

I updated my comment, you might also try adding flex styles to the component. Eg:

<GestureHandlerRootView style={{ flex: 1 }}>

systemride · 2021-11-26T18:50:44Z

@systemride Thanks for sharing. Are you also using codepush?

No, not using codepush.

wemow · 2021-11-26T18:52:03Z

Damn, I did not even thought about that, I ended up using patch-package to patch the module and return instead of throw, I don't have any overrides on my MainActivity.java, it's working fine, I may try your way tho thanks!

nchase · 2021-12-13T18:55:51Z

@federicot You asked if another user was using Codepush.

Are you aware of a relationship between Codepush and this crash?

My team is seeing an increase in crashes with this stacktrace, and it's not clear to us why. Unlike @systemride , we are using Codepush, and the crashes seem to have increased after a Codepush.

jbaudanza · 2021-12-13T18:59:25Z

@federicot You asked if another user was using Codepush.

Are you aware of a relationship between Codepush and this crash?

My team is seeing an increase in crashes with this stacktrace, and it's not clear to us why. Unlike @systemride , we are using Codepush, and the crashes seem to have increased after a Codepush.

Our team is also using Codepush. Crashes with this stack trace is pretty common after a codepush restart on Android. We have our app wrapped in GestureHandlerRootView, but maybe something about the codepush restart causes this to become unmounted? I'm planning on looking more into it this week.

federicot · 2021-12-14T08:41:07Z

@federicot You asked if another user was using Codepush.

Are you aware of a relationship between Codepush and this crash?

My team is seeing an increase in crashes with this stacktrace, and it's not clear to us why. Unlike @systemride , we are using Codepush, and the crashes seem to have increased after a Codepush.

@nchase We are seeing a slight correlation when we do codepush releases. There's also this related issue #1724

stephenkopylov · 2021-12-14T09:21:20Z

We use codepush too

aleksandr-senichev · 2021-12-14T10:12:52Z

As a temporal solution, we made a fork of stack navigator and replaced the GestureHandlerRootView wrapper with View for the Android app, because it doesn't use any gesture feature in our case. It works stable now.

jayshah-swiggy · 2021-12-16T11:14:55Z

Codepush user, also seeing similar crash

aamagda · 2021-12-17T09:08:00Z

We have the same issue after the codepush releases

aamagda · 2021-12-20T21:31:55Z

There is interesting analysis by @netshade
#715 (comment)

@kmagiera Hi, could you explain please the reason for checking rootViewTag < 1 and not for rootViewTag == View.NO_ID inside tryInitializeHandlerForReactRootView(ancestorViewTag: Int) method?

Do you have a plan to fix this issue or maybe any workarounds? What do you think about this advice #1675 (comment)

jbaudanza · 2021-12-20T22:38:21Z

I was able to resolve this issue in my project. The problem is that Codepush.restartApp doesn't actually restart the app. Instead, it uses the ReactNativeInstanceManager class to reload the bundle:

https://github.com/facebook/react-native/blob/4fb49cd555942caba1515b6a03f8ccea931dfc90/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L435

This means that if any RN-GestureHandler components begin initializing before a Codepush.restartApp, there is a very good chance that when they finish., the RootNode doesn't exist anymore. This is what causes the crash.

To solve this, you have to make sure there are no instances of RN-GestureHandler in the process of loading before a Codepush.restartApp operation. This includes things like react-navigation, which will mount gesture handlers behind the scenes.

In our case, when our app loads we begin a codepush sync. While the codepush is in any of these states, we render a simple View with no gesture handlers or react-navigation are mounted: CHECKING_FOR_UPDATE, DOWNLOADING_PACKAGE, UPDATE_INSTALLED, INSTALLING_UPDATE.

Only after the codepush is completely finished, it's safe to mount any react-navigation components.

scesbron · 2021-12-21T17:18:31Z

I have the same problem with code push in production. What I don't understand is that it is not systematic and in staging we are not able to reproduce it.

jbaudanza · 2021-12-21T17:34:10Z

I have the same problem with code push in production. What I don't understand is that it is not systematic and in staging we are not able to reproduce it.

It's not systematic because it's a race condition between 'attachGestureHandler' and codepush/ReactNativeInstanceHandler. If the gesture handler wins, then there is no crash. If you try it on an older Android phone, you should be able to reproduce it. I have a Samsung galaxy J3 and can reproduce it fairly often.

nchase · 2021-12-21T20:55:44Z

Does anyone have steps that we can follow to consistently reproduce this bug? (ideally in an emulator)

basurahan · 2021-12-28T05:02:57Z

+1

tijs · 2022-01-12T07:46:52Z

We have a lot of these crashes but we do not use codepush so while it seems to be triggered by a codepush restart it can also happen in apps that do not use codepush at all.

brduck · 2022-01-20T18:53:03Z

We're facing the same issue with OTA updates by expo-updates. It's happening since we upgraded react native to 0.66

kperdomo1 · 2022-01-21T11:07:49Z

we found a way to test this out. In our case, our codePush installMode uses the ON_NEXT_RESUME strategy, so after downloading the codePush update it is installed when user comes back to the foreground.

Launch an android emulator with low resources (in our case, 343 MB of RAM, 48PB of VM heap, 2 multi-core CPU)
Find a way to trigger attaching a new gesture handler. In our case, it was enough to navigate to other screen when the app state changes from background to active.
Release an update to CodePush so you can download it in your app.
Launch your app and wait for the CodePush update to be downloaded
Set app to the background
Come back to the foreground
At this point the race condition pointed out by @jbaudanza should happen and the app crashes.

Hope this helps

cglacet · 2022-02-14T09:19:52Z

The error doesn't say "Could not find" but "Could find".

nchase · 2022-02-22T16:23:03Z

@systemride have you discovered any issues related to your workaround?

nchase · 2022-02-22T16:56:55Z

This next one is more of a question for the maintainers: why is it desirable to throw an error in this case?

systemride · 2022-02-22T16:59:41Z

@systemride have you discovered any issues related to your workaround?

So far we have not discovered any other issues to our workaround but it's still something we want to revisit.

Also maybe worth noting... that while we don't use codepush, we do use react-native-restart which might do something similar to codepush.

leofolive · 2022-03-02T20:10:49Z

+1

johnsoncwb · 2022-03-04T14:17:08Z

same problem here, any solution?

leofolive · 2022-03-04T14:17:14Z

We're facing the same issue with OTA updates by expo-updates. It's happening since we upgraded react native to 0.66
@j-piasecki @kmagiera

nchase · 2022-03-04T14:29:53Z

@kmagiera maybe this is a question that you can answer, since it seems that you may have written this code originally: why does this library throw an error in this case?

deboralbarros · 2022-03-09T19:06:15Z

We have the same issue here, any updates?

leofolive · 2022-03-11T13:51:51Z

We're facing the same issue with OTA updates by expo-updates. It's happening since we upgraded react native to 0.66
@j-piasecki @kmagiera

leofolive · 2022-03-16T13:57:38Z

We're facing the same issue with OTA updates by expo-updates. It's happening since we upgraded react native to 0.66
@j-piasecki @kmagiera

itenl · 2022-03-21T08:42:22Z

0.66.2 + react-native-gesture-handler + CodePush same issues

`tryInitializeHandlerForReactRootView` was causing crashes, especially with combination with CodePush. `RNGestureHandlerEnabledRootView` was deprecated in version 2.0.0 in favor of `GestureHandlerRootView` component and this PR removes implementation of `RNGestureHandlerEnabledRootView` and code responsible for interactions with it. Adds a new page in docs explaining how to migrate to `GestureHandlerRootView`. Potentially fixes #1675.

nchase · 2022-04-06T19:05:47Z

Thank you, @j-piasecki ❤️

Has anyone had time to try #1936 as a patch?

abdymm · 2022-08-23T21:29:31Z

hi @LFMAKER @brduck are you guys find a way to solve this on expo?

xwartz · 2023-05-25T02:04:01Z

are there any solutions?

sebas21 · 2023-08-16T01:01:24Z

any solution??? RN 0.69

VashaMasha · 2023-09-04T13:54:08Z

This may not really be a fix, but we found a workaround for this that is working well for us. We are using:
"react-native": "0.66.1",
"react-native-gesture-handler": "1.8.0",
Remove the Override in MainActivity.java:
-  @Override
-  protected ReactActivityDelegate createReactActivityDelegate() {
-    return new ReactActivityDelegate(this, getMainComponentName()) {
-      @Override
-      protected ReactRootView createRootView() {
-       return new RNGestureHandlerEnabledRootView(MainActivity.this);
-      }
-    };
-  }
Add the GestureHandlerRootView to your app.
+ import { GestureHandlerRootView } from "react-native-gesture-handler";

...

+ <GestureHandlerRootView style={{ flex: 1 }}>
+   <App/>
+ </GestureHandlerRootView>
This step might not be necessary and probably not recommended by the library authors, but we also forked our own version and made the following changes to RNGestureHandlerModule.java:
- throw new JSApplicationIllegalArgumentException("Could find root view for a given ancestor with tag "
              + ancestorViewTag);
... and just return instead of throwing. Honestly we're not exactly sure of the ramifications of this, but the app seems to behave normally in this scenario.
+ return;

Thank you!
Worked for me

"react-native": "0.67.2",
"react-native-gesture-handler": "2.2.0",

Version numbers stayed the same and I don't have the code from step 3. So I only implemented steps 1 and 2

federicot mentioned this issue Nov 25, 2021

bug: FATAL EXCEPTION: mqt_native_modules #1724

Closed

nchase mentioned this issue Dec 21, 2021

[Android] Why rollback exists only Android? microsoft/react-native-code-push#2192

Closed

j-piasecki added the Platform: Android This issue is specific to Android label Jan 5, 2022

j-piasecki mentioned this issue Mar 17, 2022

Effectively remove RNGestureHandlerEnabledRootView #1936

Merged

j-piasecki mentioned this issue Mar 28, 2022

Play store report details crash in app only in production #1916

Closed

3 tasks

j-piasecki closed this as completed in #1936 Mar 30, 2022

santhoshvai mentioned this issue May 5, 2022

Bug - "Could not find root view for a given ancestor with tag" error in the Sample App GetStream/stream-chat-react-native#1339

Closed

jimhunty mentioned this issue Dec 5, 2022

chore: React Native Gesture Handler update guardian/editions#2138

Merged

Could not find root view for a given ancestor with tag #1675

Could not find root view for a given ancestor with tag #1675

Comments

federicot commented Oct 7, 2021

Description

Screenshots

Steps To Reproduce

Package versions

alexfov commented Oct 13, 2021

farafonoff commented Oct 18, 2021

sapramit commented Oct 26, 2021 • edited

jcdhlzq commented Oct 29, 2021 • edited

rdeift commented Nov 2, 2021

ThienNgn commented Nov 4, 2021

systemride commented Nov 10, 2021

aleksandr-senichev commented Nov 16, 2021

leofolive commented Nov 18, 2021

stephenkopylov commented Nov 22, 2021

wemow commented Nov 23, 2021

anatooly commented Nov 25, 2021

systemride commented Nov 25, 2021 • edited

federicot commented Nov 26, 2021

wemow commented Nov 26, 2021

systemride commented Nov 26, 2021

systemride commented Nov 26, 2021

wemow commented Nov 26, 2021 • edited

nchase commented Dec 13, 2021

jbaudanza commented Dec 13, 2021

federicot commented Dec 14, 2021

stephenkopylov commented Dec 14, 2021

aleksandr-senichev commented Dec 14, 2021 • edited

jayshah-swiggy commented Dec 16, 2021

aamagda commented Dec 17, 2021

aamagda commented Dec 20, 2021

jbaudanza commented Dec 20, 2021

scesbron commented Dec 21, 2021

jbaudanza commented Dec 21, 2021

nchase commented Dec 21, 2021

basurahan commented Dec 28, 2021

tijs commented Jan 12, 2022

brduck commented Jan 20, 2022

kperdomo1 commented Jan 21, 2022

cglacet commented Feb 14, 2022

nchase commented Feb 22, 2022 • edited

nchase commented Feb 22, 2022

systemride commented Feb 22, 2022

leofolive commented Mar 2, 2022

johnsoncwb commented Mar 4, 2022

leofolive commented Mar 4, 2022 • edited

nchase commented Mar 4, 2022

deboralbarros commented Mar 9, 2022

leofolive commented Mar 11, 2022

leofolive commented Mar 16, 2022

itenl commented Mar 21, 2022

nchase commented Apr 6, 2022

abdymm commented Aug 23, 2022

xwartz commented May 25, 2023

sebas21 commented Aug 16, 2023

VashaMasha commented Sep 4, 2023

sapramit commented Oct 26, 2021 •

edited

jcdhlzq commented Oct 29, 2021 •

edited

systemride commented Nov 25, 2021 •

edited

wemow commented Nov 26, 2021 •

edited

aleksandr-senichev commented Dec 14, 2021 •

edited

nchase commented Feb 22, 2022 •

edited

leofolive commented Mar 4, 2022 •

edited