[0.61.0-rc.0] `-[RCTRootView cancelTouches]` is deprecated and will be deleted soon. #746

Johan-dutoit · 2019-08-30T10:51:27Z

New warning in the latest React Native RC.

Relevant code:

https://github.com/kmagiera/react-native-gesture-handler/blob/8f0b33f5e93fe71b968da3a51c2f6d91a0f91996/ios/RNGestureHandlerManager.m#L162

shlaikov · 2019-09-16T11:18:27Z

@Johan-dutoit did you manage to eliminate the warning?
I do not have swipe left and right on the iOS. Perhaps this is the reason.

Johan-dutoit · 2019-09-16T11:28:50Z

I just silenced the warning for now and continued using it.

mikehardy · 2019-09-25T15:27:44Z

I just noticed this too. For people new to react-native that don't know how to silence, I have this in my bootstrap so I can work through issues in the upstream repos (like this one). Now that I've subscribed to this issue so I'll get updates, I add an entry for silencing like so:

YellowBox.ignoreWarnings([
  //'Warning: Async Storage has been extracted',
  'Battery state',
  'componentWillMount',
  'componentWillUpdate',
  'componentWillReceiveProps',
  '[location] ERROR - 0',
  'Warning: DatePickerAndroid', // will be fixed with https://github.com/mmazzarolo/react-native-modal-datetime-picker/pull/262
  'RCTRootView cancelTouches', // https://github.com/kmagiera/react-native-gesture-handler/issues/746
]);

cheers

Under-Warz · 2019-09-27T09:00:17Z

it's good to silent the warning, but it's better when it's fixed ;)

mikehardy · 2019-09-27T13:26:15Z

Oh absolutely @Under-Warz ! Just saying (as a person that maintains some modules) that I wasn't prepared to dive in and PR myself, and it seems like @Johan-dutoit has already provided the needed details, so in the absence of effort from myself I wasn't going to moan about it ;-). Maybe as the deprecation end time / API removal gets closer either I or someone else will go for the bonus internet points and propose a fix via a PR here

r0b0t3d · 2019-09-29T08:00:48Z

There is the PR but closed #657
Related commit facebook/react-native@36307d8

m4rcoperuano · 2019-10-02T15:55:53Z

I'm noticing that this caused crashes on iOS though (when running on a release variant. Anyone else countered this issue?

cayodonatti · 2019-10-02T16:02:28Z

I had some crashes too. Adding
import 'react-native-gesture-handler'
at the top of index.js solved it for me, despite some inconsistences that arose from the drawer component.

perlo27 · 2019-10-03T12:48:40Z

I'm getting this error when focusing TextInput, and the app freezes after that.

m4rcoperuano · 2019-10-03T13:04:56Z

The crash was resolved for me by @cayodonatti suggestion.
import 'react-native-gesture-handler'
at the very top of your index.js

The cancelTouch thing, i just added it to the ignore warning list for now until RN fixes it. No more issues here. Sorry for your freezing error perlo. I wonder if its due to another issue? I thought the cancelTouches warning was causing my app to crash. But in the end it was due to that react-native-gesture-handler not being in my index.js file

perlo27 · 2019-10-03T13:09:21Z

I've tried to add import to index.js, but it doesn't help
Probably it's some other issue, will try to investigate
thanks for response anyways!

cayodonatti · 2019-10-03T13:10:38Z

As far as I've looked into it, the two things are not directly related. It seems that the cancelTouches event deprecation comes from RN core, so I've also added it to ignored warnings. This might prove to be a problem in a future release if the event is in fact removed.
The import thingy was also not really a mistake in your part, the docs do not state it as needed and it doesn't really make sense since the components are imported individually. I got the hint from an old closed issue in this repo.
Either the docs need to be update or this is really a bug

perlo27 · 2019-10-03T13:26:09Z

Yes it's completely separate issue
sorry for the confusion

betoharres · 2019-10-08T17:30:23Z

I'm having this problem when working with react-native-maps. This error stops the map from working properly on iOS; not sure why but the map becomes incredibly unresponsive, and funny enough, I can only move the map on two tiny spots on the screen.

Every time I try to drag the map, it keep throwing the [RCTRootView cancelTouches] warning, and it cancels the dragging.

:(

System:
    OS: Linux 5.1 Arch Linux undefined
    CPU: (6) x64 Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
    Memory: 2.63 GB / 15.59 GB
    Shell: 5.7.1 - /usr/bin/zsh
  Binaries:
    Node: 11.15.0 - /usr/bin/node
    Yarn: 1.17.3 - ~/.yarn/bin/yarn
    npm: 6.10.0 - /usr/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    Android SDK:
      API Levels: 26, 28, 29
      Build Tools: 26.0.3, 28.0.3, 29.0.0
      System Images: android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.1 => 0.61.1
  npmGlobalPackages:
    react-native-cli: 2.0.1

Edit: works fine on Android. ( No warnings too )

wesleynfreitas · 2019-10-16T07:07:51Z

I try put

1 - import 'react-native-gesture-handler' at the top of index.js
2 - YellowBox.ignoreWarnings([
'RCTRootView cancelTouches'
]);

And don't works. Any news about the solution?

osmanyz · 2019-10-16T10:28:52Z

Hi guys, I have same error.

torcoste · 2019-10-16T20:05:41Z

I try put

1 - import 'react-native-gesture-handler' at the top of index.js
2 - YellowBox.ignoreWarnings([
'RCTRootView cancelTouches'
]);

And don't works. Any news about the solution?

@wesleynfreitas
That's weird.
Try this one:

YellowBox.ignoreWarnings([
  '`-[RCTRootView cancelTouches]` is deprecated and will be deleted soon.', // https://github.com/kmagiera/react-native-gesture-handler/issues/746
]);

Do you have crash or warning?

ghost · 2019-10-17T07:54:34Z

I am using RN 0.61.2 and adding
import 'react-native-gesture-handler';
to the index.js top can fix it.

quizzy · 2019-10-17T11:16:34Z

I'm getting crashes in release builds too 😞
react-native: 0.61.0
react-native-gesture-handler: 1.4.1
react-native-navigation: 3.2.0

On the simulator in dev build, the warnings appear, when using gestures, but no crashes.
I tried adding import 'react-native-gesture-handler' at the top of my index.ios.js (i.e. require('react-native-gesture-handler') but this doesn't fix the crash for me.

gestureHandlerRootHOC is already being used when calling Navigation.registerComponent as suggested by the docs (was working before the upgrade to react-native 0.61.

Any other suggestions?

(Crash happens on iOS only, android is fine).

David-Melo · 2019-10-17T15:10:02Z

@quizzy @donaldkeung @wesleynfreitas
This is my main index.js showing how i was able to get the warning suppressed. I have not tried to run on a device so I have not experienced any crashes.

quizzy · 2019-10-17T15:23:41Z

Thanks @David-Melo - I can suppress the warning, but my main concern is the crashing on iOS releases.

fyi - it looks like you have a typo in your ignoreWarnings. 'CTRootView cancelTouches' should be RCTRootView cancelTouches.

tranthienhau · 2019-10-18T04:30:00Z

Add 2 line at top your index.js import {YellowBox} from 'react-native'; YellowBox.ignoreWarnings([ '`-[RCTRootView cancelTouches]` is deprecated and will be deleted soon.', ]);

Working!!!

kidmysoul · 2019-10-18T07:47:44Z

@perlo27
hey,
how did you fix you issue on textinput freeze ? I have the same issue too.

Oh...
I found it : facebook/react-native#26707

perlo27 · 2019-10-18T07:53:15Z

@kidmysoul
It kinda works with new xcode, also erasing simulator settings and content helps

alesdvorakcz · 2019-10-20T14:55:01Z

Disabling error is nice but in release it still crashes. Is there any workaround for that? I tried importing react-native-gesture-handler at top level index.js but without any effect.

JuanCamilo0809 · 2019-10-24T13:33:38Z

I'm getting crashes in release builds too 😞
react-native: 0.61.0
react-native-gesture-handler: 1.4.1
react-native-navigation: 3.2.0

On the simulator in dev build, the warnings appear, when using gestures, but no crashes.
I tried adding import 'react-native-gesture-handler' at the top of my index.ios.js (i.e. require('react-native-gesture-handler') but this doesn't fix the crash for me.

gestureHandlerRootHOC is already being used when calling Navigation.registerComponent as suggested by the docs (was working before the upgrade to react-native 0.61.

Any other suggestions?

(Crash happens on iOS only, android is fine).

I have the same probelm, I am using:
"react": "16.9.0",
"react-native": "0.61.2",
"react-native-gesture-handler": "^1.4.1",
"react-native-reanimated": "^1.3.0",
"react-native-screens": "^1.0.0-alpha.23",
"react-navigation": "^4.0.10",
"react-navigation-drawer": "^2.2.2",
"react-navigation-stack": "^1.9.4",

When I test in emulator only show the alert, but in production from appstore, the application carsh.

Thanks for all.

swingywc · 2019-10-24T17:04:21Z

I am still developing my app and didn't release it to production yet.

I only get this yellow box warning when focusing the <TextInput /> component which inside react-navigation-stack's navigator, while the other situation is fine.
You can read more details of my situation here to see any difference with yours: react-navigation/stack#274.

I have tried adding import 'react-native-gesture-handler' at the top of the index.js file which at the root level but it's still not working.

I cannot agree to use the method to ignore yellow box warning as it should be a real problem which blocks the way to release the app. Hoping someone can find a solution to fix this error.

zaynv · 2019-10-25T01:43:34Z

@JuanCamilo0809 did you test the release build on simulator or only the debug build? Do you mean that even if release build works on Simulator, it can still fail when downloaded from app store? That is scary :(

mikehardy · 2019-10-25T01:47:13Z

#796 is in progress I think, to just fix this. But @zaynv I would never trust a build I had only checked on the Simulator. The Android Emulators are full VMs and give you a good idea things are okay but the Simulator is a completely different style of simulation. I've had release builds that only failed on devices

purnomoeko · 2019-10-25T10:44:52Z

I found a good solution for this if you encountered in ios 13 simulator https://forums.developer.apple.com/thread/122972

It could be a temporary fix, but I found it helpful.

klosowsk · 2019-10-27T02:22:28Z

Same here, it works for android but not for IOS.
Even when I do:

`import 'react-native-gesture-handler';`
... #### ...
import {gestureHandlerRootHOC} from 'react-native-gesture-handler';
AppRegistry.registerComponent(appName, () => gestureHandlerRootHOC(App));

"react": "16.9.0",
"react-native": "0.61.2",
"react-native-maps": "^0.26.1",
"react-native-reanimated": "^1.3.0",
"react-native-gesture-handler": "^1.4.1",

The YellowBox works, but it crashes the app in production, so it's not a valid solution, any updates?

mehulmpt · 2019-10-27T18:05:08Z

+1

Crashes for me too on production (iOS/RN 0.61.2). My code:

require('react-native-gesture-handler')
const {gestureHandlerRootHOC} = require('react-native-gesture-handler')
AppRegistry.registerComponent(appName, () => gestureHandlerRootHOC(App))

Any fix?

jjv360 · 2019-10-28T07:56:28Z

Hi, this is crashing for me on iOS Release build too, also react-native 0.61.2 and react-native-gesture-handler 1.4.1.

Adding import 'react-native-gesture-handler' to the top of my index.js appears to have fixed it.

Here are the crash details:

*** Terminating app due to uncaught exception 'RCTFatalException: Unhandled JS Exception: Invariant Violation: Unsupported top level event type "onGestureHandlerStateChange" dispatched', reason: 'Unhandled JS Exception: Invariant Violation: Unsupported top level event type "onGestureHandlerStateChange" dispatched

zaynv · 2019-10-28T08:14:02Z

Is this something that can be tested before an app is published to the app store? Would doing a release build and then manually installing the build onto a physical device be enough to test it or is this a crash that only happens when the app is downloaded from the store?

mikehardy · 2019-10-28T13:19:41Z

For me it was crashing on local release builds on physical devices reproducibly, especially when closing a drawer

swingywc · 2019-10-30T09:17:58Z

For anyone facing this problem,
@osdnk and @kmagiera have already fixed this issue and pushed a new version v1.5.0.
You can now fix this error by updating the package.json with following:

"react-native-gesture-handler": "^1.5.0",

and npm install again. Cheers!

jsancho · 2019-10-30T10:40:02Z

For anyone facing this problem,
@osdnk and @kmagiera have already fixed this issue and pushed a new version v1.5.0.
You can now fix this error by updating the package.json with following:
"react-native-gesture-handler": "^1.5.0",
and npm install again. Cheers!

Sorry to say this hasn't worked for me.

I've upgraded to 1.5.0 & done a full clean release build.
It keeps crashing on iOS

What works as a temporary fix is the suggestion from @jjv360

Adding import 'react-native-gesture-handler' to the top of my index.js appears to have fixed it.

mikehardy · 2019-10-30T17:44:55Z

@jsancho this may be conflating issues. The title of this one is for deprecated cancelTouches.

I think you are thinking of #320 (incorrectly closed I think) with PR in progress #792

leosena777 · 2019-10-30T21:17:47Z

@jsancho @mikehardy
I just upgraded to version 1.5.0 and the yellowbox warning is gone. Looks like it's ok: D

Note: Remember to update the ios folder pods and rebuild the project.

mikehardy · 2019-10-30T21:21:01Z

Indeed - I just went through it myself and hadn't come back here yet, but I was able to remove my yellow-box ignore line for this issue. I believe it can be closed now with 1.5.0

Still working through #792 / #320 but as I mentioned above they are separate

superguineapig · 2019-10-31T00:23:39Z

EDIT: confirmed v1.5.0 is working after performing a deep clean of local dev env as suggested in #746 (comment)

@mikehardy @leosena777
I'm still seeing the yellowbox warning with 1.5.0 on iOS sim

Have deleted node_modules, yarn.lock, Podfile.lock, and Pods did a full yarn install and pod install as well as reset simulator instances.

Perhaps I still don't have the magic combination of deps.
How do yours compare with these?:

"react": "16.9.0",
"react-native": "0.61.3",
"react-native-gesture-handler": "^1.5.0",
"react-native-reanimated": "^1.3.0",
"react-native-screens": "^1.0.0-alpha.23",
"react-navigation": "^4.0.10",
"react-navigation-drawer": "^2.3.3",
"react-navigation-stack": "^1.10.3",
"react-navigation-tabs": "^2.5.6",

Note: warning is generated when either tapping outside of a focused TextInput, or tapping outside of an open react navigation drawer to dismiss it.

Note2: adding import 'react-native-gesture-handler' has no apparent effect either. Checked just in case.

Thanks for reading!

mikehardy · 2019-10-31T02:56:47Z

I tested it on iOS, by tapping outside a navigator to dismiss it. It's gone. I suspect you still have dirty DerivedData or something - the caching on iOS builds is brutal. Do the full clean with npx react-native-clean-project and see if that gets you the behavior you want. Just moving to 1.5.0 of this package should be enough (assuming it actually takes effect as intended)

jsancho · 2019-10-31T11:19:35Z

#792

you're 100% right on this, sorry I mixed up things by having too many tabs opened!
Now tracking the PR you mentioned, thanks @mikehardy

tomasf10 · 2019-10-31T12:36:05Z

@jsancho @mikehardy
I just upgraded to version 1.5.0 and the yellowbox warning is gone. Looks like it's ok: D

Note: Remember to update the ios folder pods and rebuild the project.

It worked for me. Thanks! These are the steps I did:

Upgrade react-native-gesture-handler in terminal. So I got v1.5.0
Went to the iOS folder to update the pods: pod install
Delete the build folder and delete the app on the simulator.
Back to terminal: cd .. -> react-native run-ios and the alert was gone.

superguineapig · 2019-10-31T15:45:46Z

#746 (comment)

@mikehardy Yep, I was indeed stuck in cache-land. A deep clean seems to have worked. v1.5.0 fix confirmed. Thanks for the info!

I suspect the culprit was the ios/build dir in my case. I typically clean it when running builds via XCode. This time I was doing a CLI build and didn't think about it. Apologies for noise in the thread.

mikehardy · 2019-10-31T16:21:55Z

Great - sounds like we're 100% confirmed working then on the deprecation fix so far @kmagiera - nice!

markozxuu · 2019-11-01T07:30:43Z

It had the same problem but it updated the package and it was fixed 🙏 😄

Dunky45 · 2019-11-05T11:18:39Z

My app still crashes whenever I make any gesture based move. I have tried importing at top of index.js, upgrading to 1.5.0, clean building and still nothing. Happens only in release version on iOS :-(

EDIT:
OK finally got it!!! Some steps were not obvious to me.
At top of index.js also add
import { gestureHandlerRootHOC } from 'react-native-gesture-handler';
and also do this AppRegistry.registerComponent(appName, () => gestureHandlerRootHOC(App));

scarlac · 2019-12-18T17:20:35Z

For those trying out gestureHandlerRootHOC - it literally does nothing on iOS. It's a wrapper function returns the same component, unchanged.

Please upgrade to version 1.5.0 or later. This issue was fixed in this commit
(although not clearly mentioned in the changelog).

I think it's fair to close this issue now, @Johan-dutoit ?

software-mansion/react-native-gesture-handler#746

jakub-gonet · 2020-08-24T14:01:51Z

Seems resolved.

jeremybarbet mentioned this issue Oct 1, 2019

rctrootview canceltouches is deprecated jeremybarbet/react-native-modalize#67

Closed

phantom1299 mentioned this issue Oct 4, 2019

Don't call deprecated [RCTRootView cancelTouches] #657

Closed

satya164 mentioned this issue Oct 11, 2019

Deprecation warning "[RTCRootView cancleTouches] is deprecated" react-navigation/react-navigation#6368

Closed

jeremybarbet mentioned this issue Oct 12, 2019

Update RNN example to RN 0.59.9 jeremybarbet/react-native-modalize#70

Closed

cipriancaba mentioned this issue Oct 21, 2019

react-navigation-drawer [RCTRootView CancelTouches] is deprecated. react-navigation/react-navigation#6386

Closed

markozxuu mentioned this issue Nov 1, 2019

Fixe the bug [RCTRootView cancelTouches] markozxuu/app-anesthesiology#2

Merged

fabOnReact added a commit to fabOnReact/surf-react-native that referenced this issue Jan 7, 2020

fixing RCTRootView cancelTouches is deprecated

836689f

software-mansion/react-native-gesture-handler#746

jakub-gonet closed this as completed Aug 24, 2020

[0.61.0-rc.0] -[RCTRootView cancelTouches] is deprecated and will be deleted soon. #746

[0.61.0-rc.0] -[RCTRootView cancelTouches] is deprecated and will be deleted soon. #746

Comments

Johan-dutoit commented Aug 30, 2019 • edited Loading

shlaikov commented Sep 16, 2019 • edited Loading

Johan-dutoit commented Sep 16, 2019

mikehardy commented Sep 25, 2019

Under-Warz commented Sep 27, 2019

mikehardy commented Sep 27, 2019

r0b0t3d commented Sep 29, 2019

m4rcoperuano commented Oct 2, 2019

cayodonatti commented Oct 2, 2019

perlo27 commented Oct 3, 2019

m4rcoperuano commented Oct 3, 2019

perlo27 commented Oct 3, 2019

cayodonatti commented Oct 3, 2019

perlo27 commented Oct 3, 2019 • edited Loading

betoharres commented Oct 8, 2019 • edited Loading

wesleynfreitas commented Oct 16, 2019

osmanyz commented Oct 16, 2019

torcoste commented Oct 16, 2019 • edited Loading

ghost commented Oct 17, 2019 • edited by ghost Loading

quizzy commented Oct 17, 2019 • edited Loading

David-Melo commented Oct 17, 2019

quizzy commented Oct 17, 2019

tranthienhau commented Oct 18, 2019

kidmysoul commented Oct 18, 2019 • edited Loading

perlo27 commented Oct 18, 2019

alesdvorakcz commented Oct 20, 2019

JuanCamilo0809 commented Oct 24, 2019

swingywc commented Oct 24, 2019

zaynv commented Oct 25, 2019

mikehardy commented Oct 25, 2019

purnomoeko commented Oct 25, 2019

klosowsk commented Oct 27, 2019

mehulmpt commented Oct 27, 2019

jjv360 commented Oct 28, 2019 • edited Loading

zaynv commented Oct 28, 2019

mikehardy commented Oct 28, 2019

swingywc commented Oct 30, 2019

jsancho commented Oct 30, 2019

mikehardy commented Oct 30, 2019

leosena777 commented Oct 30, 2019 • edited Loading

mikehardy commented Oct 30, 2019

superguineapig commented Oct 31, 2019 • edited Loading

mikehardy commented Oct 31, 2019

jsancho commented Oct 31, 2019

tomasf10 commented Oct 31, 2019

superguineapig commented Oct 31, 2019

mikehardy commented Oct 31, 2019

markozxuu commented Nov 1, 2019

Dunky45 commented Nov 5, 2019 • edited Loading

scarlac commented Dec 18, 2019 • edited Loading

jakub-gonet commented Aug 24, 2020

[0.61.0-rc.0] `-[RCTRootView cancelTouches]` is deprecated and will be deleted soon. #746

[0.61.0-rc.0] `-[RCTRootView cancelTouches]` is deprecated and will be deleted soon. #746

Johan-dutoit commented Aug 30, 2019 •

edited

Loading

shlaikov commented Sep 16, 2019 •

edited

Loading

perlo27 commented Oct 3, 2019 •

edited

Loading

betoharres commented Oct 8, 2019 •

edited

Loading

torcoste commented Oct 16, 2019 •

edited

Loading

ghost commented Oct 17, 2019 •

edited by ghost

Loading

quizzy commented Oct 17, 2019 •

edited

Loading

kidmysoul commented Oct 18, 2019 •

edited

Loading

jjv360 commented Oct 28, 2019 •

edited

Loading

leosena777 commented Oct 30, 2019 •

edited

Loading

superguineapig commented Oct 31, 2019 •

edited

Loading

Dunky45 commented Nov 5, 2019 •

edited

Loading

scarlac commented Dec 18, 2019 •

edited

Loading