Change invocation order of methods when resetting gesture recognizers #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
pushed a commit
to wordpress-mobile/react-native-gesture-handler
that referenced
this pull request
Feb 25, 2022
Changed order of method invocations in `reset` method of gesture recognizers. `triggerAction` should be called before resetting the `pointerTracker`, as it in turn may reset the GestureHandler they are associated with. This causes GestureHandler to set its cached `lastState` to `UNDETERMINED` which was breaking the state flow when using `touchEvents`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed order of method invocations in
resetmethod of gesture recognizers.triggerActionshould be called before resetting thepointerTracker, as it in turn may reset the GestureHandler they are associated with. This causes GestureHandler to set its cachedlastStatetoUNDETERMINEDwhich was breaking the state flow when usingtouchEvents.Test plan
Tested on the Example app