fix: kotlin compiler error inferred type Context? #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On what version of React Native have you got this error? |
|
3 tasks
Kudo
added a commit
to expo/expo
that referenced
this pull request
Oct 6, 2022
gnprice
added a commit
to gnprice/zulip-mobile
that referenced
this pull request
Nov 9, 2022
This is needed in order to bump compileSdkVersion to 33 without hitting this build error: software-mansion/react-native-gesture-handler#2096 The upgrade requires a change in our Android MainActivity class, like so: https://docs.swmansion.com/react-native-gesture-handler/docs/guides/migrating-off-rnghenabledroot/
chrisbobbe
pushed a commit
to gnprice/zulip-mobile
that referenced
this pull request
Nov 11, 2022
This is needed in order to bump compileSdkVersion to 33 without hitting this build error: software-mansion/react-native-gesture-handler#2096 The upgrade requires a change in our Android MainActivity class, like so: https://docs.swmansion.com/react-native-gesture-handler/docs/guides/migrating-off-rnghenabledroot/ For the details of that change, we follow Expo's template app: expo/expo@a2dc4da94 Discussion here: zulip#5543 (comment)
BrandonNgoranNtam
pushed a commit
to BrandonNgoranNtam/zulip-mobile
that referenced
this pull request
Nov 22, 2022
This is needed in order to bump compileSdkVersion to 33 without hitting this build error: software-mansion/react-native-gesture-handler#2096 The upgrade requires a change in our Android MainActivity class, like so: https://docs.swmansion.com/react-native-gesture-handler/docs/guides/migrating-off-rnghenabledroot/ For the details of that change, we follow Expo's template app: expo/expo@a2dc4da94 Discussion here: zulip#5543 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR will fix android compile error
Type mismatch: inferred type is Context? but Context was expectedTest plan
manual build on existing apps