Returning Swipeable reference #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code allows me to do the following two things:
1. Close any previously opened Swipeable views when one is opened
````
const openedRow = useRef();
function renderItem({item: payable, index, separators}) {
return (
<Swipeable
onSwipeableWillOpen={() => openedRow.current?.close()} // Close a previously opened row
onSwipeableOpen={(_, swipeable) => (openedRow.current = swipeable)} // Keep a link to the currenlty
````
2. Close a Swipeable view when it is being deleted.
````
renderRightActions={(_, __, swipeable) => {
return (
<TouchableOpacity
onPress={() => {
swipeable.close(); // Close the Swipeable when the user presses the button
````
j-piasecki
requested changes
Jun 20, 2022
|
Any updates on this one? |
j-piasecki
requested changes
Sep 20, 2022
j-piasecki
reviewed
Sep 20, 2022
j-piasecki
approved these changes
Sep 20, 2022
j-piasecki
pushed a commit
that referenced
this pull request
Apr 5, 2023
## Description <!-- Description and motivation for this PR. Include 'Fixes #<number>' if this is fixing some issue. --> #2105 returned the Swipeable reference, but only for `renderRightActions`. This MR aims to return that same reference on `renderLeftActions` also. The use case is the same. ## Test plan <!-- Describe how did you test this change here. --> I've been using my fork on a few personal projects and it's working as expected.
|
Excuse me, isn't it ip you opened row 1 and close it, when you open it again, it will auto close? I'm facing this issue right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following code allows me to do the following two things:
Resolves this issue: #764
Test plan
Made these changes in my own app and used patch-package. It has been working fine for my needs.