Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Example app run on web #2110

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

j-piasecki
Copy link
Member

Description

This PR makes changes necessary to make Example app run on web:

  • adds react-native-web as a dependency
  • modifies web-specific babel config to be more in line with the default one and maps react-native to react-native-web
  • removes the underscore from 60_000 in the Camera example as it was causing errors on web (and some older iPhones IIRC)

Test plan

Checked if any of the test cases crashes (those that use Gesture.Exclusive do, but they should be fixed by #2058, and Manual Gestures example crashes as Gesture.Manual is not implemented on web).

@j-piasecki j-piasecki merged commit bc585dd into main Jul 12, 2022
@j-piasecki j-piasecki deleted the @jpiasecki/fix-example-app-on-web branch July 12, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant