Make Gesture Handler on web respect simultaneousHandlers prop when used on a ScrollView
#2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taneous with a NativeGestureHandler
j-piasecki
force-pushed
the
@jpiasecki/fix-web-simultaneous-with-native
branch
from
427c247
to
094342c
Compare
tomekzaw
requested changes
Aug 2, 2022
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
|
Oops, looks like the changes I've suggested are not formatted properly. |
tomekzaw
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should fix #2091
HammerJS (which is used by Gesture Handler on web) by default tries to use pointer events, which can be cancelled when the browser starts recognizing its own gestures (e.g. scrolling). Because of that all gestures would fail upon receiving
pointercancelevent. This is not the case when using touch events, which do not get cancelled.This PR forces Hammer to use touch events when a gesture is simultaneous with a
NativeViewGestureHandlerand keeps its default behavior in other cases. This way the gesture keeps receiving events event when a browses is handling a gesture be itself.Unfortunately, I don't think we can accomplish feature-parity between web and native platforms using Hammer. For example, one of the missing things is the possibility to prevent the scroll from starting.
Test plan
Tested on the Example app and on the code from the issue.