Export custom RefreshControl component and add logic required to handle it
#2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Aug 2, 2022
tomekzaw
reviewed
Aug 2, 2022
tomekzaw
reviewed
Aug 2, 2022
tomekzaw
approved these changes
Aug 2, 2022
j-piasecki
added a commit
that referenced
this pull request
Sep 22, 2022
## Description #2137 added a custom `RefreshControl` component and the logic necessary to handle it. I missed one use case in that PR: a custom component that renders the added `RefreshControl`. This PR fixes this by cloning the provided component instead of copying the props. ## Test plan ```jsx const RefreshControlWrapper = React.forwardRef((props, ref) => { const [refreshing, setRefreshing] = React.useState(false); useEffect(() => { setTimeout(() => { setRefreshing(false); }, 1000); }, [refreshing]); return ( <RefreshControl ref={ref} refreshing={refreshing} onRefresh={() => { setRefreshing(true); }}> {props.children} </RefreshControl> ); }); export default function App() { return ( <GestureHandlerRootView style={{ flex: 1 }}> <ScrollView refreshControl={<RefreshControlWrapper />}> <View style={{ width: 100, height: 200, backgroundColor: 'red' }} /> <View style={{ width: 100, height: 200, backgroundColor: 'green' }} /> <View style={{ width: 100, height: 200, backgroundColor: 'blue' }} /> <View style={{ width: 100, height: 200, backgroundColor: 'red' }} /> <View style={{ width: 100, height: 200, backgroundColor: 'green' }} /> <View style={{ width: 100, height: 200, backgroundColor: 'blue' }} /> </ScrollView> </GestureHandlerRootView> ); } ```
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1067.
The problem with
RefreshControlon Android was that it wasn't a part of the Gesture Handler system. This PR adds a customRefreshControlcomponent exported by GH in the same way asScrollView,Switchetc. It also adds custom logic toScrollViewandFlatListcomponents exported by Gesture Handler that handles setting relations between native gestures properly.Test plan
Tested on the Example app and on code from the issue